[SPARK-24810][SQL] Fix paths to test files in AvroSuite #21773
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #93027 has finished for PR 21773 at commit
|
|
Test build #93028 has finished for PR 21773 at commit
|
| val episodesFile = "src/test/resources/episodes.avro" | ||
| val testFile = "src/test/resources/test.avro" | ||
| val episodesAvro = "episodes.avro" | ||
| val testAvro = "test.avro" |
Member
There was a problem hiding this comment.
Nit:
Maybe we can make it simpler
val episodesAvro = testFile("episodes.avro")
val testAvro = testFile("test.avro")
|
Test build #4212 has finished for PR 21773 at commit
|
|
Test build #93033 has finished for PR 21773 at commit
|
|
Test build #93035 has finished for PR 21773 at commit
|
Member
|
retest this please |
|
Test build #93039 has finished for PR 21773 at commit
|
gatorsmile
reviewed
Jul 16, 2018
Member
gatorsmile
left a comment
gatorsmile
left a comment
There was a problem hiding this comment.
LGTM
Thanks! Merged to master
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Jul 16, 2018
## What changes were proposed in this pull request? In the PR, I propose to move `testFile()` to the common trait `SQLTestUtilsBase` and wrap test files in `AvroSuite` by the method `testFile()` which returns full paths to test files in the resource folder. Author: Maxim Gekk <[email protected]> Closes apache#21773 from MaxGekk/test-file.
otterc
pushed a commit
to linkedin/spark
that referenced
this pull request
Mar 22, 2023
In the PR, I propose to move `testFile()` to the common trait `SQLTestUtilsBase` and wrap test files in `AvroSuite` by the method `testFile()` which returns full paths to test files in the resource folder. Author: Maxim Gekk <[email protected]> Closes apache#21773 from MaxGekk/test-file. (cherry picked from commit 9f92945)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to move
testFile()to the common traitSQLTestUtilsBaseand wrap test files inAvroSuiteby the methodtestFile()which returns full paths to test files in the resource folder.