Skip to content

[SPARK-22357][CORE] SparkContext.binaryFiles ignore minPartitions parameter #21638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bomeng wants to merge 4 commits into from
Closed

[SPARK-22357][CORE] SparkContext.binaryFiles ignore minPartitions parameter #21638

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9eea49
fix: SparkContext.binaryFiles ignore minPartitions parameter
bomeng Jun 25, 2018
0fc35d4
should be max()
bomeng Jun 25, 2018
c24fbe5
fix the issue
bomeng Jun 26, 2018
5e46efb
Merge remote-tracking branch 'upstream/master' into 22357
Aug 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/main/scala/org/apache/spark/input/PortableDataStream.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ private[spark] abstract class StreamFileInputFormat[T]
* which is set through setMaxSplitSize
*/
def setMinPartitions(sc: SparkContext, context: JobContext, minPartitions: Int) {
val defaultMaxSplitBytes = sc.getConf.get(config.FILES_MAX_PARTITION_BYTES)
val defaultMaxSplitBytes = Math.max(
sc.getConf.get(config.FILES_MAX_PARTITION_BYTES), minPartitions)
val openCostInBytes = sc.getConf.get(config.FILES_OPEN_COST_IN_BYTES)
val defaultParallelism = sc.defaultParallelism
Copy link
Member

@viirya viirya Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, shouldn't minPartitions be used like this?

val defaultParallelism = Math.max(sc.defaultParallelism, if (minPartitions == 0) 1 else minPartitions)

Copy link
Member

@MaxGekk MaxGekk Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you describe the use case when you need to take into account minPartitions. By default, FILES_MAX_PARTITION_BYTES is 128MB. Let's say it is even set to 1000, and minPartitions equals to 10 000. What is the reason to set the max size of splits in bytes to the min number of partition. Why should bigger number of partitions require bigger split size? Could you add more details to the PR description, please.

val files = listStatus(context).asScala
Expand Down