[SPARK-23776][DOC] Update instructions for running PySpark after building with SBT #21628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #92278 has finished for PR 21628 at commit
|
bersprockets
commented
Jun 25, 2018
|
|
||
| If you are building PySpark with SBT and wish to run the PySpark tests, you will need to build Spark with Hive support and also build the test components: | ||
|
|
||
| ./build/sbt -Phive clean package |
Contributor
Author
There was a problem hiding this comment.
I noticed that the pyspark tests were recently changed so that -Phive is no longer strictly necessary to run pyspark tests, but I decided not to address that in this update.
Member
There was a problem hiding this comment.
Yea, I think we don't necessarily mention it now.
HyukjinKwon
approved these changes
Jun 25, 2018
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
LGTM except for the comments above.
|
|
||
| If you are building PySpark with SBT and wish to run the PySpark tests, you will need to build Spark with Hive support and also build the test components: | ||
|
|
||
| ./build/sbt -Phive clean package |
Member
There was a problem hiding this comment.
Yea, I think we don't necessarily mention it now.
docs/building-spark.md
Outdated
| If you are building PySpark with SBT and wish to run the PySpark tests, you will need to build Spark with Hive support and also build the test components: | ||
|
|
||
| ./build/sbt -Phive clean package | ||
| ./build/sbt sql/test:compile |
Member
There was a problem hiding this comment.
Hm, shouldn't we better compile other tests too?
|
Test build #92311 has finished for PR 21628 at commit
|
Member
|
Merged to master. |
Contributor
Author
|
@HyukjinKwon Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This update tells the reader how to build Spark with SBT such that pyspark-sql tests will succeed.
If you follow the current instructions for building Spark with SBT, pyspark/sql/udf.py fails with:
How was this patch tested?
I ran the doc build command (SKIP_API=1 jekyll build) and eyeballed the result.