[Spark-24553][WEB-UI] http 302 fixes for href redirect #21600
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM. |
SJKallman
changed the title
Member
|
I am pretty sure he meant something like ok to test |
SJKallman
changed the title
Member
|
not a big deal but let's remove |
Member
|
retest this please |
Contributor
Author
|
Updated title and PR description. Happy to hear thoughts and collaborate on a better solution just let me know. |
|
Test build #92155 has finished for PR 21600 at commit
|
Member
|
retest this please |
|
Test build #92163 has finished for PR 21600 at commit
|
Member
|
Thanks! Merged to master |
asfgit
pushed a commit
that referenced
this pull request
Nov 22, 2018
## What changes were proposed in this pull request? This PR is a follow-up PR of #21600 to fix the unnecessary UI redirect. ## How was this patch tested? Local verification Closes #23116 from jerryshao/SPARK-24553. Authored-by: jerryshao <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
jerryshao
added a commit
to jerryshao/apache-spark
that referenced
this pull request
Nov 23, 2018
## What changes were proposed in this pull request? This PR is a follow-up PR of apache#21600 to fix the unnecessary UI redirect. ## How was this patch tested? Local verification Closes apache#23116 from jerryshao/SPARK-24553. Authored-by: jerryshao <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 76aae7f) Signed-off-by: jerryshao <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Nov 23, 2018
## What changes were proposed in this pull request? This is a backport PR of #23116 . This PR is a follow-up PR of #21600 to fix the unnecessary UI redirect. ## How was this patch tested? Local verification Closes #23121 from jerryshao/SPARK-24553-branch-2.4. Authored-by: jerryshao <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? This PR is a follow-up PR of apache#21600 to fix the unnecessary UI redirect. ## How was this patch tested? Local verification Closes apache#23116 from jerryshao/SPARK-24553. Authored-by: jerryshao <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Jul 23, 2019
## What changes were proposed in this pull request? This is a backport PR of apache#23116 . This PR is a follow-up PR of apache#21600 to fix the unnecessary UI redirect. ## How was this patch tested? Local verification Closes apache#23121 from jerryshao/SPARK-24553-branch-2.4. Authored-by: jerryshao <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Aug 1, 2019
## What changes were proposed in this pull request? This is a backport PR of apache#23116 . This PR is a follow-up PR of apache#21600 to fix the unnecessary UI redirect. ## How was this patch tested? Local verification Closes apache#23121 from jerryshao/SPARK-24553-branch-2.4. Authored-by: jerryshao <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Updated URL/href links to include a '/' before '?id' to make links consistent and avoid http 302 redirect errors within UI port 4040 tabs.
How was this patch tested?
Built a runnable distribution and executed jobs. Validated that http 302 redirects are no longer encountered when clicking on links within UI port 4040 tabs.
Author: Steven Kallman [email protected]