Skip to content

Conversation

@RussellSpitzer
Copy link
Member

This may be useful when Java 8 is no longer supported since
Scala 2.11.12 supports later versions of Java

What changes were proposed in this pull request?

Change Scala Build Version to 2.11.12.

How was this patch tested?

This PR is made to run 2.11.12 Scala through Jenkins to see whether or not it passes cleanly.

Please review http://spark.apache.org/contributing.html before opening a pull request.

This may be useful when Java 8 is no longer supported since
Scala 2.11.12 supports later versions of Java
@dbtsai
Copy link
Member

dbtsai commented May 29, 2018

I'm also looking at this issue. The challenge is that one of the hacks we use to initialize the Spark
before REPL sees any files was removed in Scala 2.11.12.

https://github.com/apache/spark/blob/master/repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala#L109

We might need to work with Scala team to upgrade our Scala version.

@dbtsai
Copy link
Member

dbtsai commented May 29, 2018

Here is the issue in Scala side. scala/bug#10913

@rxin
Copy link
Contributor

rxin commented May 29, 2018

Jenkins, test this please.

@rxin
Copy link
Contributor

rxin commented May 29, 2018

Jenkins, add to whitelist.

@HyukjinKwon
Copy link
Member

Jenkins, test this please

@HyukjinKwon
Copy link
Member

Jenkins, add to whitelist

@SparkQA
Copy link

SparkQA commented May 31, 2018

Test build #91322 has finished for PR 21453 at commit 90d3842.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jerryshao
Copy link
Contributor

Scala 2.11.12 cannot be built against with current Spark, due to some method changes in REPL. We have tried internally.

@dbtsai
Copy link
Member

dbtsai commented May 31, 2018

I filed an issue in Scala community about the interface changes, and they said those REPL apis are intended to be private. scala/bug#10913

Being said that, they gave us couple ways to walk around it, and I'm testing it now.

@dbtsai
Copy link
Member

dbtsai commented Jun 5, 2018

I opened a PR for Scala 2.11.12 with potential Scala API change fix. #21495 Thanks.

@jerryshao
Copy link
Contributor

I think we can close this one as a dup of #21495 .

@SparkQA
Copy link

SparkQA commented Jul 11, 2018

Test build #92866 has finished for PR 21453 at commit 90d3842.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen srowen mentioned this pull request Jul 18, 2018
@asfgit asfgit closed this in 1a4fda8 Jul 19, 2018
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
Closes apache#17422
Closes apache#17619
Closes apache#18034
Closes apache#18229
Closes apache#18268
Closes apache#17973
Closes apache#18125
Closes apache#18918
Closes apache#19274
Closes apache#19456
Closes apache#19510
Closes apache#19420
Closes apache#20090
Closes apache#20177
Closes apache#20304
Closes apache#20319
Closes apache#20543
Closes apache#20437
Closes apache#21261
Closes apache#21726
Closes apache#14653
Closes apache#13143
Closes apache#17894
Closes apache#19758
Closes apache#12951
Closes apache#17092
Closes apache#21240
Closes apache#16910
Closes apache#12904
Closes apache#21731
Closes apache#21095

Added:
Closes apache#19233
Closes apache#20100
Closes apache#21453
Closes apache#21455
Closes apache#18477

Added:
Closes apache#21812
Closes apache#21787

Author: hyukjinkwon <[email protected]>

Closes apache#21781 from HyukjinKwon/closing-prs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants