-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-23934][SQL] Adding map_from_entries function #21282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
mn-mikke
wants to merge
11
commits into
apache:master
from
AbsaOSS:feature/array-api-map_from_entries-to-master
Closed
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8c6039c
[SPARK-23934][SQL] Adding map_from_entries function
mn-mikke 25aa879
[SPARK-23934][SQL] Addressing review comments
mn-mikke 8d12d9f
[SPARK-23934][SQL] Resolving conflicts.
mn-mikke 7fd824e
[SPARK-23934][SQL] Merging master to the feature branch.
mn-mikke 45e4633
Merge remote-tracking branch 'spark/master' into feature/array-api-ma…
mn-mikke 83165e0
[SPARK-23934][SQL] Merging master to the feature branch.
mn-mikke 10ace84
[SPARK-23934][SQL] Ignoring key duplicities
mn-mikke 6cca713
Merge remote-tracking branch 'spark/master' into feature/array-api-ma…
mn-mikke 44c513c
Merge remote-tracking branch 'spark/master' into feature/array-api-ma…
mn-mikke 599656e
[SPARK-23934][SQL] Handling of null entries
mn-mikke 4eaedc5
[SPARK-23934][SQL] Fixing scala style
mn-mikke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should throw an exception if
arrayData.isNullAt(i)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ueshin,
wouldn't it be better return
nullin this case? And follow null handling of other functions likeflatten?WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that sounds reasonable. Thanks.