Skip to content

Conversation

@bakea
Copy link

@bakea bakea commented Apr 26, 2018

What changes were proposed in this pull request?

JIRA Issue:https://issues.apache.org/jira/browse/SPARK-21645
Change the optimize rule of leftouter join, if the filter column is contained in join column, the can synchronize the filter from left to right, For example, left join sql:
Select * from a left outer join b on a.id=b.id where a.id=12345;

After join optimizer rule, the filter a.id = 12345 of table a should be synchronized to table b(b.id=12345)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

To see the query plan by explain the sql like 'Select * from a left outer join b on a.id=b.id where a.id=12345', guarantee the filter a.id=12345 is synchronized to table b.

@bakea bakea changed the title left outer join synchronize the condition from left table to right [SPARK-21645]left outer join synchronize the condition from left table to right Apr 26, 2018
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@wangyum
Copy link
Member

wangyum commented Nov 10, 2018

I think it has fixed by SPARK-21479.

@asfgit asfgit closed this in a3ba3a8 Nov 11, 2018
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
Closes apache#21766
Closes apache#21679
Closes apache#21161
Closes apache#20846
Closes apache#19434
Closes apache#18080
Closes apache#17648
Closes apache#17169

Add:
Closes apache#22813
Closes apache#21994
Closes apache#22005
Closes apache#22463

Add:
Closes apache#15899

Add:
Closes apache#22539
Closes apache#21868
Closes apache#21514
Closes apache#21402
Closes apache#21322
Closes apache#21257
Closes apache#20163
Closes apache#19691
Closes apache#18697
Closes apache#18636
Closes apache#17176

Closes apache#23001 from wangyum/CloseStalePRs.

Authored-by: Yuming Wang <[email protected]>
Signed-off-by: hyukjinkwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants