-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-19724][SQL][FOLLOW-UP]Check location of managed table when ignoreIfExists is true #21001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #89011 has finished for PR 21001 at commit
|
|
retest this please. |
|
Test build #89017 has finished for PR 21001 at commit
|
|
Test build #89050 has finished for PR 21001 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message is
"Table or view 'tbl' already exists in database 'default';"
This is soft of behavior change, as we check table existence first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of deleting the test, we should change the name of the table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We check table existence in SessionCatalog instead of ExternalCatalog now.
SessionCatalogSuite has similar test case, so no need to create new one.
|
Test build #89072 has finished for PR 21001 at commit
|
|
Test build #89071 has finished for PR 21001 at commit
|
|
Test build #89080 has finished for PR 21001 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not remove this logic here, even it's also done in SessionCatalog
ffd0c66 to
c4f359a
Compare
|
Test build #89115 has finished for PR 21001 at commit
|
|
LGTM Thanks! Merged to master. |
|
Test build #89124 has finished for PR 21001 at commit
|
What changes were proposed in this pull request?
In the PR #20886, I mistakenly check the table location only when
ignoreIfExistsis false, which was following the original deprecated PR.That was wrong. When
ignoreIfExistsis true and the target table doesn't exist, we should also check the table location. In other word,ignoreIfExistshas nothing to do with table location validation.This is a follow-up PR to fix the mistake.
How was this patch tested?
Add one unit test.