[SPARK-23835][SQL] Add not-null check to Tuples' arguments deserialization #20976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #88892 has finished for PR 20976 at commit
|
Contributor
Author
|
retest this please |
|
Test build #88903 has finished for PR 20976 at commit
|
|
Test build #88940 has finished for PR 20976 at commit
|
Contributor
Author
|
retest this please |
Contributor
Author
|
UT errors were caused by another commit which has been reverted. |
|
Test build #88949 has finished for PR 20976 at commit
|
|
Test build #88975 has finished for PR 20976 at commit
|
Contributor
Author
Contributor
Author
|
kindly ping @cloud-fan @marmbrus @viirya |
Contributor
|
LGTM, can you add an end-to-end test case in |
|
Test build #89444 has finished for PR 20976 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Apr 17, 2018
…ation ## What changes were proposed in this pull request? There was no check on nullability for arguments of `Tuple`s. This could lead to have weird behavior when a null value had to be deserialized into a non-nullable Scala object: in those cases, the `null` got silently transformed in a valid value (like `-1` for `Int`), corresponding to the default value we are using in the SQL codebase. This situation was very likely to happen when deserializing to a Tuple of primitive Scala types (like Double, Int, ...). The PR adds the `AssertNotNull` to arguments of tuples which have been asked to be converted to non-nullable types. ## How was this patch tested? added UT Author: Marco Gaido <[email protected]> Closes #20976 from mgaido91/SPARK-23835. (cherry picked from commit 0a9172a) Signed-off-by: Wenchen Fan <[email protected]>
Contributor
|
thanks, merging to master/2.3! |
Member
|
ah, a late LGTM. |
otterc
pushed a commit
to linkedin/spark
that referenced
this pull request
Mar 22, 2023
…ation There was no check on nullability for arguments of `Tuple`s. This could lead to have weird behavior when a null value had to be deserialized into a non-nullable Scala object: in those cases, the `null` got silently transformed in a valid value (like `-1` for `Int`), corresponding to the default value we are using in the SQL codebase. This situation was very likely to happen when deserializing to a Tuple of primitive Scala types (like Double, Int, ...). The PR adds the `AssertNotNull` to arguments of tuples which have been asked to be converted to non-nullable types. added UT Author: Marco Gaido <[email protected]> Closes apache#20976 from mgaido91/SPARK-23835. Ref: LIHADOOP-48531 RB=1850759 G=superfriends-reviewers R=mshen,zolin,latang,fli,yezhou A=
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There was no check on nullability for arguments of
Tuples. This could lead to have weird behavior when a null value had to be deserialized into a non-nullable Scala object: in those cases, thenullgot silently transformed in a valid value (like-1forInt), corresponding to the default value we are using in the SQL codebase. This situation was very likely to happen when deserializing to a Tuple of primitive Scala types (like Double, Int, ...).The PR adds the
AssertNotNullto arguments of tuples which have been asked to be converted to non-nullable types.How was this patch tested?
added UT