[SPARK-23802][SQL] PropagateEmptyRelation can leave query plan in unresolved state #20914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ok to test |
|
Test build #88630 has finished for PR 20914 at commit
|
Author
|
|
Contributor
|
retest this please |
|
Test build #88642 has finished for PR 20914 at commit
|
Member
|
retest this please |
|
Test build #88646 has finished for PR 20914 at commit
|
added 4 commits
March 29, 2018 12:37
robert3005
force-pushed
the
rk/propagate-empty-fix
branch
from
be950e4 to
d9a2ee8
Compare
|
Test build #88705 has finished for PR 20914 at commit
|
robert3005
commented
Mar 29, 2018
| .where(left) | ||
| .join(testRelation2.where(right), joinType = jt, condition = Some('a.attr == 'b.attr)) | ||
| val optimized = Optimize.execute(query.analyze) | ||
| val optimized = Optimize.execute(query.analyze).analyze |
Author
There was a problem hiding this comment.
the subsequent analyze here is to fill in timezones on casts inserted by Optimize
Member
There was a problem hiding this comment.
We should fill the time zone in the optimizer rule
|
Test build #88717 has finished for PR 20914 at commit
|
gatorsmile
reviewed
Mar 30, 2018
| // Construct a project list from plan's output, while the value is always NULL. | ||
| private def nullValueProjectList(plan: LogicalPlan): Seq[NamedExpression] = | ||
| plan.output.map{ a => Alias(Literal(null), a.name)(a.exprId) } | ||
| plan.output.map{ a => Alias(Cast(Literal(null), a.dataType), a.name)(a.exprId) } |
|
Test build #88759 has finished for PR 20914 at commit
|
Author
|
@gatorsmile how does it look now? |
Member
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Apr 4, 2018
…esolved state ## What changes were proposed in this pull request? Add cast to nulls introduced by PropagateEmptyRelation so in cases they're part of coalesce they will not break its type checking rules ## How was this patch tested? Added unit test Author: Robert Kruszewski <[email protected]> Closes #20914 from robert3005/rk/propagate-empty-fix. (cherry picked from commit 5cfd5fa) Signed-off-by: gatorsmile <[email protected]>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Apr 4, 2018
…esolved state ## What changes were proposed in this pull request? Add cast to nulls introduced by PropagateEmptyRelation so in cases they're part of coalesce they will not break its type checking rules ## How was this patch tested? Added unit test Author: Robert Kruszewski <[email protected]> Closes apache#20914 from robert3005/rk/propagate-empty-fix.
mshtelma
pushed a commit
to mshtelma/spark
that referenced
this pull request
Apr 5, 2018
…esolved state ## What changes were proposed in this pull request? Add cast to nulls introduced by PropagateEmptyRelation so in cases they're part of coalesce they will not break its type checking rules ## How was this patch tested? Added unit test Author: Robert Kruszewski <[email protected]> Closes apache#20914 from robert3005/rk/propagate-empty-fix.
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
…esolved state Add cast to nulls introduced by PropagateEmptyRelation so in cases they're part of coalesce they will not break its type checking rules Added unit test Author: Robert Kruszewski <[email protected]> Closes apache#20914 from robert3005/rk/propagate-empty-fix. (cherry picked from commit 5cfd5fa) Signed-off-by: gatorsmile <[email protected]> Change-Id: I9c673e572454a9fa43e296b7fe66e7f2fc569854
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add cast to nulls introduced by PropagateEmptyRelation so in cases they're part of coalesce they will not break its type checking rules
How was this patch tested?
Added unit test