Skip to content

Conversation

@chucheng92
Copy link
Member

What changes were proposed in this pull request?

Easy fix in the markdown.

How was this patch tested?

Tested manually

Please review http://spark.apache.org/contributing.html before opening a pull request.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@felixcheung
Copy link
Member

can you check if we have other typo in the md file?
or similar type of typo in other md files?

@chucheng92
Copy link
Member Author

chucheng92 commented Mar 23, 2018

@felixcheung Yes, I read the entire docs of Spark Mlib. There is no problem with other mds (I may not have seen it or other contributors solved it). This error is obvious, and it affects the link of the later issue, so i found it.
http://spark.apache.org/docs/latest/ml-guide.html#breaking-changes

@chucheng92
Copy link
Member Author

@felixcheung hi,In my reading process,I found another md file typos and fix it. Do I need to close this pr and merge it into one commit and give a new pr? Thanks.

@HyukjinKwon
Copy link
Member

I think you can add all other typos into here.

@chucheng92
Copy link
Member Author

@HyukjinKwon Thanks a lot, could u help me to review these commits if u have time。

@chucheng92
Copy link
Member Author

can someone help me to close this pr? i have merged these commits to a new pr.
#20897

@felixcheung
Copy link
Member

@lemonjing you need to close the PR from github.com - we don't have access to close it

@chucheng92
Copy link
Member Author

@felixcheung thanks a lot. and i closed it.

@chucheng92 chucheng92 closed this Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants