[SPARK-23728][BRANCH-2.3] Fix ML tests with expected exceptions running streaming tests #20852
Conversation
|
Test build #88345 has finished for PR 20852 at commit
|
|
Hi, @yanboliang and @jkbradley . |
| exception.getCause != null && ( | ||
| hasExpectedMessageDirectly(exception.getCause) || ( | ||
| exception.getCause.getCause != null && | ||
| hasExpectedMessageDirectly(exception.getCause.getCause)))) |
There was a problem hiding this comment.
Why not use a loop to check inner exception ? So it can check any deep level exception msg.
Maybe we cannot make sure the possible root exception max level (even in master version)
@jkbradley What do you think ?
There was a problem hiding this comment.
I don't think we need to loop further. If the real message is buried this deep, that could be considered a problem in and of itself.
|
Apologies for breaking it! This LGTM I'll go ahead and merge it to fix the build, but please comment further on this PR as needed. |
|
Merging with branch-2.3 |
…ng streaming tests ## What changes were proposed in this pull request? The testTransformerByInterceptingException failed to catch the expected message on 2.3 during streaming tests as the feature generated message is not at the direct caused by exception but even one level deeper. ## How was this patch tested? Running the unit tests. Author: “attilapiros” <[email protected]> Closes #20852 from attilapiros/SPARK-23728.
|
Thank you, @jkbradley and @attilapiros . |
|
(@attilapiros, just in case it should be manually closed) |
|
Closing manually as it was merged to branch-2.3. |
…ng streaming tests ## What changes were proposed in this pull request? The testTransformerByInterceptingException failed to catch the expected message on 2.3 during streaming tests as the feature generated message is not at the direct caused by exception but even one level deeper. ## How was this patch tested? Running the unit tests. Author: “attilapiros” <[email protected]> Closes apache#20852 from attilapiros/SPARK-23728.
6 participants
What changes were proposed in this pull request?
The testTransformerByInterceptingException failed to catch the expected message on 2.3 during streaming tests as the feature generated message is not at the direct caused by exception but even one level deeper.
How was this patch tested?
Running the unit tests.