-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-23653][SQL] Show sql statement in spark SQL UI #20803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9d2098d
[SPARK-23653][SQL] Show sql statement in spark SQL UI
LantaoJin 4712379
fix the variable substitution problem like `${var}`, `${env:var}`
LantaoJin 6f8bc0d
change sql text to DF and fix the problems mentioned in review
LantaoJin 92293c6
simplify the code about sql text in DF
LantaoJin 89e8e74
workaround for the Scala bug
LantaoJin df98d83
count() shouldn't show sql text
LantaoJin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,6 +34,16 @@ object SQLExecution { | |
|
|
||
| private val executionIdToQueryExecution = new ConcurrentHashMap[Long, QueryExecution]() | ||
|
|
||
| private val executionIdToSqlText = new ConcurrentHashMap[Long, String]() | ||
|
|
||
| def setSqlText(sqlText: String): Unit = { | ||
| executionIdToSqlText.putIfAbsent(_nextExecutionId.get(), sqlText) | ||
| } | ||
|
|
||
| def getSqlText(executionId: Long): String = { | ||
| executionIdToSqlText.get(executionId) | ||
|
||
| } | ||
|
|
||
| def getQueryExecution(executionId: Long): QueryExecution = { | ||
| executionIdToQueryExecution.get(executionId) | ||
| } | ||
|
|
@@ -63,16 +73,17 @@ object SQLExecution { | |
| val oldExecutionId = sc.getLocalProperty(EXECUTION_ID_KEY) | ||
| val executionId = SQLExecution.nextExecutionId | ||
| sc.setLocalProperty(EXECUTION_ID_KEY, executionId.toString) | ||
| val sqlText = getSqlText(executionId) | ||
| executionIdToQueryExecution.put(executionId, queryExecution) | ||
| try { | ||
| // sparkContext.getCallSite() would first try to pick up any call site that was previously | ||
| // set, then fall back to Utils.getCallSite(); call Utils.getCallSite() directly on | ||
| // streaming queries would give us call site like "run at <unknown>:0" | ||
| val callSite = sparkSession.sparkContext.getCallSite() | ||
|
|
||
| sparkSession.sparkContext.listenerBus.post(SparkListenerSQLExecutionStart( | ||
| executionId, callSite.shortForm, callSite.longForm, queryExecution.toString, | ||
| SparkPlanInfo.fromSparkPlan(queryExecution.executedPlan), System.currentTimeMillis())) | ||
| SparkPlanInfo.fromSparkPlan(queryExecution.executedPlan), | ||
| System.currentTimeMillis(), sqlText)) | ||
| try { | ||
| body | ||
| } finally { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the executionId used here match the current execution? IIUC, the execution id is incremented in
withNewExecutionId, and the one you used here mostly refers to the previous execution, please correct me if I'm wrong.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setSqlTextis invoked beforewithNewExecutionId. First time_nextExecutionIdis 0 by default, sosetSqlTextstore (0, x) in map. WhenwithNewExecutionIdis invoked, the codeval executionId = SQLExecution.nextExecutionIdincrease the execution id and return the previous execution id, 0. Thenval sqlText = getSqlText(executionId)will return the sql text which 0 mapped, x. Next time whensetSqlTextis invoked, _nextExecutionId.get() return the increased id, 1. So the new sql text store in map (1, y).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh, I see. Sorry I misunderstood it.