Skip to content

[SPARK-23569][PYTHON] Allow pandas_udf to work with python3 style type-annotated functions #20728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mstewart141 wants to merge 2 commits into from
Closed

[SPARK-23569][PYTHON] Allow pandas_udf to work with python3 style type-annotated functions #20728

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cd53f3
[SPARK-23569][PYTHON] Allow pandas_udf to work with python3 style typ…
mstewart141 Mar 3, 2018
0395690
Add test
mstewart141 Mar 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion python/pyspark/sql/udf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,15 @@ def _create_udf(f, returnType, evalType):
PythonEvalType.SQL_GROUPED_AGG_PANDAS_UDF):

import inspect
import sys
from pyspark.sql.utils import require_minimum_pyarrow_version

require_minimum_pyarrow_version()
argspec = inspect.getargspec(f)

if sys.version_info[0] < 3:
argspec = inspect.getargspec(f)
else:
argspec = inspect.getfullargspec(f)
Copy link
Member

@HyukjinKwon HyukjinKwon Mar 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a small comment while we are here like 'getargspec ' is deprecated since version 3.0 and calling it with type hints causes an actual issue. See SPARK-23569?

Copy link
Contributor Author

@mstewart141 mstewart141 Mar 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can do.


if evalType == PythonEvalType.SQL_SCALAR_PANDAS_UDF and len(argspec.args) == 0 and \
argspec.varargs is None:
Expand Down