[SPARK-23310][CORE][FOLLOWUP] Fix Java style check issues. #20514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
LGTM, thanks for fixing this. |
HyukjinKwon
approved these changes
Feb 6, 2018
jiangxb1987
approved these changes
Feb 6, 2018
|
Test build #87089 has finished for PR 20514 at commit
|
Member
|
retest this please |
Member
|
LGTM |
|
Test build #87096 has finished for PR 20514 at commit
|
Member
Author
|
Jenkins, retest this please. |
|
Test build #87105 has finished for PR 20514 at commit
|
Member
|
retest this please |
|
Test build #87110 has finished for PR 20514 at commit
|
Contributor
|
Merging to master / 2.3. |
asfgit
pushed a commit
that referenced
this pull request
Feb 6, 2018
## What changes were proposed in this pull request? This is a follow-up of #20492 which broke lint-java checks. This pr fixes the lint-java issues. ``` [ERROR] src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java:[79] (sizes) LineLength: Line is longer than 100 characters (found 114). ``` ## How was this patch tested? Checked manually in my local environment. Author: Takuya UESHIN <ueshin@databricks.com> Closes #20514 from ueshin/issues/SPARK-23310/fup1. (cherry picked from commit 7db9979) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #20492 which broke lint-java checks.
This pr fixes the lint-java issues.
How was this patch tested?
Checked manually in my local environment.