[SPARK-23311][SQL][TEST]add FilterFunction test case for test CombineTypedFilters #20482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heary-cao
force-pushed
the
TypedFilterOptimizationSuite
branch
from
424bdc3 to
f45ef79
Compare
Contributor
Author
|
@cloud-fan @gatorsmile Can you help me to review it. thanks. |
Member
|
ok to test |
|
Test build #86964 has finished for PR 20482 at commit
|
heary-cao
force-pushed
the
TypedFilterOptimizationSuite
branch
from
f45ef79 to
6042523
Compare
Member
|
retest this please |
|
Test build #87021 has finished for PR 20482 at commit
|
|
Test build #87023 has finished for PR 20482 at commit
|
Member
|
Thanks! Merged to master/2.3 |
asfgit
pushed a commit
that referenced
this pull request
Feb 3, 2018
…eTypedFilters ## What changes were proposed in this pull request? In the current test case for CombineTypedFilters, we lack the test of FilterFunction, so let's add it. In addition, in TypedFilterOptimizationSuite's existing test cases, Let's extract a common LocalRelation. ## How was this patch tested? add new test cases. Author: caoxuewen <cao.xuewen@zte.com.cn> Closes #20482 from heary-cao/TypedFilterOptimizationSuite. (cherry picked from commit 63b49fa) Signed-off-by: gatorsmile <gatorsmile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the current test case for CombineTypedFilters, we lack the test of FilterFunction, so let's add it.
In addition, in TypedFilterOptimizationSuite's existing test cases, Let's extract a common LocalRelation.
How was this patch tested?
add new test cases.