[SPARK-23280][SQL][FOLLOWUP] Enable MutableColumnarRow.getMap().
#20471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
viirya
approved these changes
Feb 1, 2018
| public MapData getMap(int ordinal) { | ||
| throw new UnsupportedOperationException(); | ||
| public ColumnarMap getMap(int ordinal) { | ||
| if (columns[ordinal].isNullAt(rowId)) return null; |
Member
There was a problem hiding this comment.
I will remove this null check in #20455 later after this gets merged.
Contributor
|
LGTM |
|
Test build #86922 has finished for PR 20471 at commit
|
Member
Author
|
Thanks! merging to master/2.3. |
asfgit
pushed a commit
that referenced
this pull request
Feb 1, 2018
## What changes were proposed in this pull request? This is a followup pr of #20450. We should've enabled `MutableColumnarRow.getMap()` as well. ## How was this patch tested? Existing tests. Author: Takuya UESHIN <[email protected]> Closes #20471 from ueshin/issues/SPARK-23280/fup2. (cherry picked from commit 89e8d55) Signed-off-by: Takuya UESHIN <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup pr of #20450.
We should've enabled
MutableColumnarRow.getMap()as well.How was this patch tested?
Existing tests.