[SPARK-23293][SQL] fix data source v2 self join #20466
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #86912 has finished for PR 20466 at commit
|
Contributor
Author
|
retest this please |
|
Test build #86927 has finished for PR 20466 at commit
|
cloud-fan
force-pushed
the
dsv2-selfjoin
branch
from
6e55d10 to
05253f0
Compare
|
Test build #86934 has finished for PR 20466 at commit
|
Contributor
|
+1 Good to get this in before changes to the relation. |
Member
|
This is another bug fix of the new data source v2 Thanks! Merged to master/2.3 |
asfgit
pushed a commit
that referenced
this pull request
Feb 1, 2018
`DataSourceV2Relation` should extend `MultiInstanceRelation`, to take care of self-join. a new test Author: Wenchen Fan <[email protected]> Closes #20466 from cloud-fan/dsv2-selfjoin. (cherry picked from commit 73da3b6) Signed-off-by: gatorsmile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
DataSourceV2Relationshould extendMultiInstanceRelation, to take care of self-join.How was this patch tested?
a new test