changed scala example from java "style" to scala #20458
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
the example is written in Java, not in Scala. I think you can close this PR, thanks. |
srowen
reviewed
Jan 31, 2018
docs/quick-start.md
Outdated
| String logFile = "YOUR_SPARK_HOME/README.md"; // Should be some file on your system | ||
| SparkSession spark = SparkSession.builder().appName("Simple Application").getOrCreate(); | ||
| Dataset<String> logData = spark.read().textFile(logFile).cache(); | ||
| public class SimpleApp extends App { |
Member
There was a problem hiding this comment.
Yes, this isn't valid Java, and it's supposed to be Java. It was correct before.
Author
There was a problem hiding this comment.
Sorry, I updated the wrong section.
updated the right section, Scala.
Author
|
I just changed to the right section. |
Member
|
IIRC extending App won't work, or didn't. The example is already correct. |
Author
|
It's not just "will" work, it's working. I never said that it wasn't working, the Scala example was wrote using Java "style" not Scala "style" which . Which you don't create a main method but extends App. |
Contributor
|
Author
|
Hello Marcel,
This is an old bug and was fixed long time ago, I just runned the following
example and got the correct result:
DemoBug: rslt1 = 3 rslt2 = 3
Doesn't make sense use Java traditional way "main(...)" just because 4
years ago the "Scala approach" had a bug. Sometimes we can't use feature
because of bugs, it's fine but we should move on when they are fixed.
…On Wed, Jan 31, 2018 at 4:20 PM, Marcelo Vanzin ***@***.***> wrote:
It's not just "will" work, it's working.
https://issues.apache.org/jira/browse/SPARK-4170
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20458 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAC5fS39XmaJETebqFaYm7SzKOtDk1KVks5tQNkWgaJpZM4R0i6_>
.
--
--
Daniel de Oliveira Mantovani
Perl Evangelist/Data Hacker
+1 786 459 1341
|
Contributor
|
Did you try it with Scala 2.10? That's still supported by Spark. |
Author
|
I just tested with Scala 2.10.6 and Spark 2.1.1 and worked perfect. Since this patch won't be applied for Spark 1.x documentation, it would be fine.
18/01/31 17:21:28 INFO DAGScheduler: Job 1 finished: count at
Bootstrap.scala:14, took 0.024446 s
DemoBug: rslt1 = 3 rslt2 = 3
…On Wed, Jan 31, 2018 at 5:16 PM, Marcelo Vanzin ***@***.***> wrote:
Did you try it with Scala 2.10? That's still supported by Spark.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20458 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAC5fSAOjXpf1HNiOCQhx_BUL4GxaC4gks5tQOYggaJpZM4R0i6_>
.
--
--
Daniel de Oliveira Mantovani
Perl Evangelist/Data Hacker
+1 786 459 1341
|
Member
|
Yeah, that's what I was thinking of. Subclasses of |
Author
|
If I change all examples of the documentation will be accept ?
…On Wed, Jan 31, 2018 at 6:41 PM, Sean Owen ***@***.***> wrote:
Yeah, that's what I was thinking of. Subclasses of App don't necessarily
work in Spark (not just Scala). I don't know if that has changed as Spark
and Scala moved forward. While that's an interesting item to investigate,
here the question is changing one example to use App, while none of the
others do and there's a reason not to. We don't want to do that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20458 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAC5fXruoTYCd0hMD4wsXtMSNUYB-pz5ks5tQPohgaJpZM4R0i6_>
.
--
--
Daniel de Oliveira Mantovani
Perl Evangelist/Data Hacker
+1 786 459 1341
|
Member
|
The point is that it won't always work in Spark, so, certainly not unless you test them. I just don't think it's worth it, especially as it's setting an expectation as an example that it is the best way to do it. |
Author
|
Sean, I already tested. Can you please be more specific how should be the
tests ? I just tested on Spark 2.1.1 and Scala 2.11 and 2.10.
On Wed, Jan 31, 2018 at 19:19 Sean Owen ***@***.***> wrote:
The point is that it won't always work in Spark, so, certainly not unless
you test them. I just don't think it's worth it, especially as it's setting
an expectation as an example that it is the best way to do it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20458 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAC5fQJd6YYF8AI0tijFEkzDKExgiABUks5tQQL_gaJpZM4R0i6_>
.
--
…--
Daniel de Oliveira Mantovani
Perl Evangelist/Data Hacker
+1 786 459 1341
|
|
Can one of the admins verify this patch? |
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
Closes apache#20458 Closes apache#20530 Closes apache#20557 Closes apache#20966 Closes apache#20857 Closes apache#19694 Closes apache#18227 Closes apache#20683 Closes apache#20881 Closes apache#20347 Closes apache#20825 Closes apache#20078 Closes apache#21281 Closes apache#19951 Closes apache#20905 Closes apache#20635 Author: Sean Owen <[email protected]> Closes apache#21303 from srowen/ClosePRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I changed an example wrote in Scala using Java "style" to Scala "style".
How was this patch tested?
It's not necessary test, the language documentation should be enough. For the documentation propose.
http://www.scala-lang.org/api/2.9.2/scala/App.html
Please review http://spark.apache.org/contributing.html before opening a pull request.