[SPARK-23202][SQL] Add new API in DataSourceWriter: onDataWriterCommit #20454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengliangwang
changed the title
Member
Author
|
Test build #86871 has finished for PR 20454 at commit
|
|
Test build #86875 has finished for PR 20454 at commit
|
|
Test build #86877 has finished for PR 20454 at commit
|
Member
Author
|
retest this please. |
rdblue
reviewed
Jan 31, 2018
| * | ||
| * If this method fails (by throwing an exception), this writing job is considered to to have been | ||
| * failed, and {@link #abort(WriterCommitMessage[])} would be called. The state of the destination | ||
| * is undefined and {@link #abort(WriterCommitMessage[])} may not be able to deal with it. |
Contributor
There was a problem hiding this comment.
What does it mean that "the state of the destination is undefined"? I think it is sufficient to say that abort will be called and the contract for aborting commits applies.
Contributor
There was a problem hiding this comment.
makes sense, let's remove the last sentence.
Contributor
|
+1 I'd rather not add features without a known use case, but this implementation looks good to me. |
|
Test build #86884 has finished for PR 20454 at commit
|
|
Test build #86914 has finished for PR 20454 at commit
|
Contributor
|
adding a default method to a java interface is binary compatible, I'm merging this to master only, to follow @rxin 's suggestion about not adding new stuff to 2.3, thanks! |
jzhuge
pushed a commit
to jzhuge/spark
that referenced
this pull request
Mar 7, 2019
The current DataSourceWriter API makes it hard to implement `onTaskCommit(taskCommit: TaskCommitMessage)` in `FileCommitProtocol`. In general, on receiving commit message, driver can start processing messages(e.g. persist messages into files) before all the messages are collected. The proposal to add a new API: `add(WriterCommitMessage message)`: Handles a commit message on receiving from a successful data writer. This should make the whole API of DataSourceWriter compatible with `FileCommitProtocol`, and more flexible. There was another radical attempt in apache#20386. This one should be more reasonable. Unit test Author: Wang Gengliang <[email protected]> Closes apache#20454 from gengliangwang/write_api. (cherry picked from commit 9907bcfa045f96fb23822dc10eb3a2a42a6832d4) Conflicts: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala
rdblue
pushed a commit
to rdblue/spark
that referenced
this pull request
Apr 3, 2019
The current DataSourceWriter API makes it hard to implement `onTaskCommit(taskCommit: TaskCommitMessage)` in `FileCommitProtocol`. In general, on receiving commit message, driver can start processing messages(e.g. persist messages into files) before all the messages are collected. The proposal to add a new API: `add(WriterCommitMessage message)`: Handles a commit message on receiving from a successful data writer. This should make the whole API of DataSourceWriter compatible with `FileCommitProtocol`, and more flexible. There was another radical attempt in apache#20386. This one should be more reasonable. Unit test Author: Wang Gengliang <[email protected]> Closes apache#20454 from gengliangwang/write_api.
jzhuge
pushed a commit
to jzhuge/spark
that referenced
this pull request
Oct 15, 2019
The current DataSourceWriter API makes it hard to implement `onTaskCommit(taskCommit: TaskCommitMessage)` in `FileCommitProtocol`. In general, on receiving commit message, driver can start processing messages(e.g. persist messages into files) before all the messages are collected. The proposal to add a new API: `add(WriterCommitMessage message)`: Handles a commit message on receiving from a successful data writer. This should make the whole API of DataSourceWriter compatible with `FileCommitProtocol`, and more flexible. There was another radical attempt in apache#20386. This one should be more reasonable. Unit test Author: Wang Gengliang <[email protected]> Closes apache#20454 from gengliangwang/write_api. (cherry picked from commit 9907bcfa045f96fb23822dc10eb3a2a42a6832d4) Conflicts: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala
otterc
pushed a commit
to linkedin/spark
that referenced
this pull request
Mar 22, 2023
…nDataWriterCommit The current DataSourceWriter API makes it hard to implement `onTaskCommit(taskCommit: TaskCommitMessage)` in `FileCommitProtocol`. In general, on receiving commit message, driver can start processing messages(e.g. persist messages into files) before all the messages are collected. The proposal to add a new API: `add(WriterCommitMessage message)`: Handles a commit message on receiving from a successful data writer. This should make the whole API of DataSourceWriter compatible with `FileCommitProtocol`, and more flexible. There was another radical attempt in apache#20386. This one should be more reasonable. Unit test Author: Wang Gengliang <[email protected]> Closes apache#20454 from gengliangwang/write_api. RB=1824728 A=
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The current DataSourceWriter API makes it hard to implement
onTaskCommit(taskCommit: TaskCommitMessage)inFileCommitProtocol.In general, on receiving commit message, driver can start processing messages(e.g. persist messages into files) before all the messages are collected.
The proposal to add a new API:
add(WriterCommitMessage message): Handles a commit message on receiving from a successful data writer.This should make the whole API of DataSourceWriter compatible with
FileCommitProtocol, and more flexible.There was another radical attempt in #20386. This one should be more reasonable.
How was this patch tested?
Unit test