Skip to content

[SPARK-23157][SQL][FOLLOW-UP] DataFrame -> SparkDataFrame in R comment #20443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
henryr wants to merge 1 commit into from
Closed

[SPARK-23157][SQL][FOLLOW-UP] DataFrame -> SparkDataFrame in R comment #20443

henryr wants to merge 1 commit into from

Conversation

@henryr
Copy link
Contributor

@henryr henryr commented Jan 30, 2018

No description provided.

henryr referenced this pull request Jan 30, 2018
@gatorsmile
[SPARK-23157][SQL] Explain restriction on column expression in withCo…
8b98324 
…lumn()

## What changes were proposed in this pull request?

It's not obvious from the comments that any added column must be a
function of the dataset that we are adding it to. Add a comment to
that effect to Scala, Python and R Data* methods.

Author: Henry Robinson <[email protected]>

Closes #20429 from henryr/SPARK-23157.
@SparkQA
Copy link

SparkQA commented Jan 30, 2018

Test build #86847 has finished for PR 20443 at commit 2441e03.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

gatorsmile commented Jan 31, 2018

cc @felixcheung Could you take a look at this? Thanks!

felixcheung
felixcheung approved these changes Jan 31, 2018
View reviewed changes
Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
though you might want to fix 8b98324#r27200028 too for consistency

@SparkQA
Copy link

SparkQA commented Feb 1, 2018

Test build #86900 has finished for PR 20443 at commit 96f9284.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Feb 1, 2018
@HyukjinKwon
[SPARK-23157][SQL][FOLLOW-UP] DataFrame -> SparkDataFrame in R comment
7ccfc75 
Author: Henry Robinson <[email protected]>

Closes #20443 from henryr/SPARK-23157.

(cherry picked from commit f470df2)
Signed-off-by: hyukjinkwon <[email protected]>
@HyukjinKwon
Copy link
Member

HyukjinKwon commented Feb 1, 2018

Merged to master and branch-2.3.

@asfgit asfgit closed this in f470df2 Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srowen srowen srowen approved these changes

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

@felixcheung felixcheung felixcheung approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@henryr @SparkQA @gatorsmile @HyukjinKwon @srowen @felixcheung