[SPARK-23276][SQL][TEST] Enable UDT tests in (Hive)OrcHadoopFsRelationSuite #20440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
Jan 30, 2018
| override protected def supportsDataType(dataType: DataType): Boolean = dataType match { | ||
| case _: NullType => false | ||
| case _: CalendarIntervalType => false | ||
| case _: UserDefinedType[_] => false |
Member
Author
There was a problem hiding this comment.
Both OrcHadoopFsRelationSuite and HiveOrcHadoopFsRelationSuite enables UDT tests.
|
Test build #86843 has finished for PR 20440 at commit
|
Member
Author
|
Thank you for review, @HyukjinKwon . |
asfgit
pushed a commit
that referenced
this pull request
Jan 31, 2018
…nSuite ## What changes were proposed in this pull request? Like Parquet, ORC test suites should enable UDT tests. ## How was this patch tested? Pass the Jenkins with newly enabled test cases. Author: Dongjoon Hyun <[email protected]> Closes #20440 from dongjoon-hyun/SPARK-23276. (cherry picked from commit 7786616) Signed-off-by: gatorsmile <[email protected]>
Member
|
Thanks! Merged to master/2.3 |
Member
Author
|
Thank you, @HyukjinKwon and @gatorsmile ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Like Parquet, ORC test suites should enable UDT tests.
How was this patch tested?
Pass the Jenkins with newly enabled test cases.