Skip to content

Conversation

@ueshin
Copy link
Member

@ueshin ueshin commented Jan 30, 2018

What changes were proposed in this pull request?

This is a follow-up pr of #20338 which changed the downloaded file name of the python code style checker but it's not contained in .gitignore file so the file remains as an untracked file for git after running the checker.
This pr adds the file name to .gitignore file.

How was this patch tested?

Tested manually.

@ueshin
Copy link
Member Author

ueshin commented Jan 30, 2018

cc @rekhajoshm @HyukjinKwon

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM, too. :)

@rekhajoshm
Copy link
Contributor

👍 LGTM @ueshin

@SparkQA
Copy link

SparkQA commented Jan 30, 2018

Test build #86797 has finished for PR 20432 at commit 3fb3d78.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@ueshin
Copy link
Member Author

ueshin commented Jan 30, 2018

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jan 30, 2018

Test build #86803 has finished for PR 20432 at commit 3fb3d78.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Jan 30, 2018

Test build #86818 has finished for PR 20432 at commit 3fb3d78.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

@asfgit asfgit closed this in a23187f Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants