Skip to content

[SPARK-23238][SQL] Externalize SQLConf configurations exposed in documentation #20403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 4 commits into from
Closed

[SPARK-23238][SQL] Externalize SQLConf configurations exposed in documentation #20403

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4899e33
Minor doc correction for 'spark.sql.execution.arrow.enabled'
HyukjinKwon Jan 26, 2018
1f4d288
Address comments
HyukjinKwon Jan 26, 2018
0c05526
Externalize few more configurations mentioned in the documentation
HyukjinKwon Jan 28, 2018
fd7f5c0
Take out 'spark.sql.execution.arrow.maxRecordsPerBatch' for now
HyukjinKwon Jan 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1045,9 +1045,10 @@ object SQLConf {
buildConf("spark.sql.execution.arrow.enabled")
.internal()

@gatorsmile gatorsmile Jan 26, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conf will be mentioned in the doc #19575. I think this is not qualified as an internal conf.

@gatorsmile gatorsmile Jan 26, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change it in this PR and use this JIRA number https://issues.apache.org/jira/browse/SPARK-23238

@HyukjinKwon HyukjinKwon Jan 26, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup.

.doc("Make use of Apache Arrow for columnar data transfers. Currently available " +

@gatorsmile gatorsmile Jan 26, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When true, make use of

"for use with pyspark.sql.DataFrame.toPandas with the following data types: " +
"StringType, BinaryType, BooleanType, DoubleType, FloatType, ByteType, IntegerType, " +
"LongType, ShortType")
"for use with pyspark.sql.DataFrame.toPandas, and " +
"pyspark.sql.SparkSession.createDataFrame when its input is a Pandas DataFrame. " +
"The following data types are unsupported: " +
"MapType, ArrayType of TimestampType, and nested StructType.")
.booleanConf
.createWithDefault(false)

@viirya viirya Jan 28, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spark.sql.execution.arrow.maxRecordsPerBatch is also mentioned in the doc change at #19575. Shall we also externalize it?

@HyukjinKwon HyukjinKwon Jan 28, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Let me update spark.sql.inMemoryColumnarStorage.compressed and spark.sql.inMemoryColumnarStorage.batchSize too. These are also exposed but internals.


Expand Down