Skip to content

[SPARK-23020][CORE][FOLLOWUP] Fix Java style check issues. #20376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ueshin wants to merge 1 commit into from
Closed

[SPARK-23020][CORE][FOLLOWUP] Fix Java style check issues. #20376

ueshin wants to merge 1 commit into from

Conversation

@ueshin
Copy link
Member

@ueshin ueshin commented Jan 24, 2018

What changes were proposed in this pull request?

This is a follow-up of #20297 which broke lint-java checks.
This pr fixes the lint-java issues.

[ERROR] src/test/java/org/apache/spark/launcher/BaseSuite.java:[21,8] (imports) UnusedImports: Unused import - java.util.concurrent.TimeUnit.
[ERROR] src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java:[27,8] (imports) UnusedImports: Unused import - java.util.concurrent.TimeUnit.

How was this patch tested?

Checked manually in my local environment.

@cloud-fan
Copy link
Contributor

cloud-fan commented Jan 24, 2018

LGTM, cc @vanzin

dongjoon-hyun
dongjoon-hyun approved these changes Jan 24, 2018
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

viirya
viirya approved these changes Jan 24, 2018
View reviewed changes
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA
Copy link

SparkQA commented Jan 24, 2018

Test build #86561 has finished for PR 20376 at commit dfd828b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member

viirya commented Jan 24, 2018

retest this please.

@SparkQA
Copy link

SparkQA commented Jan 24, 2018

Test build #86574 has finished for PR 20376 at commit dfd828b.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Jan 24, 2018

retest this please

1 similar comment
@HyukjinKwon
Copy link
Member

HyukjinKwon commented Jan 24, 2018

retest this please

@SparkQA
Copy link

SparkQA commented Jan 24, 2018

Test build #86576 has finished for PR 20376 at commit dfd828b.

  • This patch fails from timeout after a configured wait of `300m`.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk
Copy link
Member

kiszk commented Jan 24, 2018

Retest this please

@SparkQA
Copy link

SparkQA commented Jan 24, 2018

Test build #86584 has finished for PR 20376 at commit dfd828b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 24, 2018

Test build #86588 has finished for PR 20376 at commit dfd828b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor

vanzin commented Jan 24, 2018

Merging to master / 2.3.

asfgit pushed a commit that referenced this pull request Jan 24, 2018
@ueshin
[SPARK-23020][CORE][FOLLOWUP] Fix Java style check issues.
2221a30 
## What changes were proposed in this pull request?

This is a follow-up of #20297 which broke lint-java checks.
This pr fixes the lint-java issues.

```
[ERROR] src/test/java/org/apache/spark/launcher/BaseSuite.java:[21,8] (imports) UnusedImports: Unused import - java.util.concurrent.TimeUnit.
[ERROR] src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java:[27,8] (imports) UnusedImports: Unused import - java.util.concurrent.TimeUnit.
```

## How was this patch tested?

Checked manually in my local environment.

Author: Takuya UESHIN <[email protected]>

Closes #20376 from ueshin/issues/SPARK-23020/fup1.

(cherry picked from commit 8c273b4)
Signed-off-by: Marcelo Vanzin <[email protected]>
@asfgit asfgit closed this in 8c273b4 Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viirya viirya viirya approved these changes

@srowen srowen srowen approved these changes

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

@felixcheung felixcheung felixcheung approved these changes

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@ueshin @cloud-fan @SparkQA @viirya @HyukjinKwon @kiszk @vanzin @srowen @felixcheung @dongjoon-hyun