Skip to content

[SPARK-23135][ui] Fix rendering of accumulators in the stage page. #20299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-23135][ui] Fix rendering of accumulators in the stage page. #20299

wants to merge 1 commit into from

Conversation

@vanzin
Copy link
Contributor

@vanzin vanzin commented Jan 17, 2018

This follows the behavior of 2.2: only named accumulators with a
value are rendered.

Screenshot:
accs

[SPARK-23135][ui] Fix rendering of accumulators in the stage page.
b639a59 
This follows the behavior of 2.2: only named accumulators with a
value are rendered.
@SparkQA
Copy link

SparkQA commented Jan 17, 2018

Test build #86291 has finished for PR 20299 at commit b639a59.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor Author

vanzin commented Jan 17, 2018

retest this please

@SparkQA
Copy link

SparkQA commented Jan 18, 2018

Test build #86301 has finished for PR 20299 at commit b639a59.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gengliangwang
Copy link
Member

gengliangwang commented Jan 18, 2018

Can we filter null accumulatorUpdates when saving into stage data? So that we don't need to do filtering on rendering pages.

@vanzin
Copy link
Contributor Author

vanzin commented Jan 18, 2018

Then they wouldn't show up in the REST API, and I'm pretty sure they showed up before.

gengliangwang
gengliangwang approved these changes Jan 19, 2018
View reviewed changes
Copy link
Member

@gengliangwang gengliangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sameeragarwal
Copy link
Member

sameeragarwal commented Jan 19, 2018

LGTM. Merging this to master/2.3. Thanks!

asfgit pushed a commit that referenced this pull request Jan 19, 2018
@sameeragarwal
[SPARK-23135][UI] Fix rendering of accumulators in the stage page.
f9ad00a 
This follows the behavior of 2.2: only named accumulators with a
value are rendered.

Screenshot:
![accs](https://user-images.githubusercontent.com/1694083/35065700-df409114-fb82-11e7-87c1-550c3f674371.png)

Author: Marcelo Vanzin <[email protected]>

Closes #20299 from vanzin/SPARK-23135.

(cherry picked from commit f6da41b)
Signed-off-by: Sameer Agarwal <[email protected]>
@asfgit asfgit closed this in f6da41b Jan 19, 2018
@vanzin vanzin deleted the SPARK-23135 branch January 22, 2018 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gengliangwang gengliangwang gengliangwang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vanzin @SparkQA @gengliangwang @sameeragarwal