[SPARK-23132][PYTHON][ML] Run doctests in ml.image when testing #20294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @MrBago and @imatiach-msft, could you take a look when you are available please? |
HyukjinKwon
commented
Jan 17, 2018
| >>> df = ImageSchema.readImages('data/mllib/images/kittens', recursive=True) | ||
| >>> df.count() | ||
| 4 | ||
| 5 |
Member
Author
There was a problem hiding this comment.
It becomes 5 since we don't dropImageFailures.
|
Test build #86268 has finished for PR 20294 at commit
|
srowen
approved these changes
Jan 17, 2018
imatiach-msft
approved these changes
Jan 17, 2018
Contributor
|
nice fix! Great to see the doctests run. |
asfgit
pushed a commit
that referenced
this pull request
Jan 17, 2018
## What changes were proposed in this pull request? This PR proposes to actually run the doctests in `ml/image.py`. ## How was this patch tested? doctests in `python/pyspark/ml/image.py`. Author: hyukjinkwon <[email protected]> Closes #20294 from HyukjinKwon/trigger-image. (cherry picked from commit 45ad97d) Signed-off-by: hyukjinkwon <[email protected]>
Member
Author
|
Merged to master and branch-2.3. Thanks for reviewing this, @srowen, @imatiach-msft, @MrBago and @BryanCutler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to actually run the doctests in
ml/image.py.How was this patch tested?
doctests in
python/pyspark/ml/image.py.