[SPARK-23089][STS] Recreate session log directory if it doesn't exist #20281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #86195 has finished for PR 20281 at commit
|
Contributor
|
LGTM. So looks like the fix is exactly the same as Hive. |
Contributor
|
@cloud-fan would you please take another look on this? |
Contributor
|
LGTM, cc @gatorsmile |
Contributor
|
@gatorsmile , do you have further comment? |
jiangxb1987
approved these changes
Jan 19, 2018
| @Override | ||
| public void setOperationLogSessionDir(File operationLogRootDir) { | ||
| if (!operationLogRootDir.exists()) { | ||
| LOG.warn("The operation log root directory is removed, recreating:" + |
Contributor
There was a problem hiding this comment.
nit: extra space at the end of line
Contributor
Author
There was a problem hiding this comment.
sorry @jiangxb1987 I can't see any extra space at the end of this line...
Contributor
There was a problem hiding this comment.
we need an extra space: ... recreating: " +
Contributor
Author
There was a problem hiding this comment.
oh sorry, now I understand, thanks! Yes, in Hive this space is still missing, I see only now. Thanks.
|
Test build #86385 has finished for PR 20281 at commit
|
Contributor
|
thanks, merging to master/2.3! |
asfgit
pushed a commit
that referenced
this pull request
Jan 19, 2018
## What changes were proposed in this pull request? When creating a session directory, Thrift should create the parent directory (i.e. /tmp/base_session_log_dir) if it is not present. It is common that many tools delete empty directories, so the directory may be deleted. This can cause the session log to be disabled. This was fixed in HIVE-12262: this PR brings it in Spark too. ## How was this patch tested? manual tests Author: Marco Gaido <[email protected]> Closes #20281 from mgaido91/SPARK-23089. (cherry picked from commit e41400c) Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When creating a session directory, Thrift should create the parent directory (i.e. /tmp/base_session_log_dir) if it is not present. It is common that many tools delete empty directories, so the directory may be deleted. This can cause the session log to be disabled.
This was fixed in HIVE-12262: this PR brings it in Spark too.
How was this patch tested?
manual tests