Skip to content

Conversation

@liyinan926
Copy link
Contributor

What changes were proposed in this pull request?

We missed enabling spark.files and spark.jars in #19954. The result is that remote dependencies specified through spark.files or spark.jars are not included in the list of remote dependencies to be downloaded by the init-container. This PR fixes it.

How was this patch tested?

Manual tests.

@vanzin This replaces #20157.

@foxish

@liyinan926 liyinan926 changed the title Enable spark.jars and spark.files in KUBERNETES mode [SPARK-22757][K8S] Enable spark.jars and spark.files in KUBERNETES mode Jan 4, 2018
@SparkQA
Copy link

SparkQA commented Jan 5, 2018

Test build #85703 has finished for PR 20160 at commit 1075cfc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixcheung
Copy link
Member

test passed, merged to master/2.3.

asfgit pushed a commit that referenced this pull request Jan 5, 2018
## What changes were proposed in this pull request?

We missed enabling `spark.files` and `spark.jars` in #19954. The result is that remote dependencies specified through `spark.files` or `spark.jars` are not included in the list of remote dependencies to be downloaded by the init-container. This PR fixes it.

## How was this patch tested?

Manual tests.

vanzin This replaces #20157.

foxish

Author: Yinan Li <[email protected]>

Closes #20160 from liyinan926/SPARK-22757.

(cherry picked from commit 6cff7d1)
Signed-off-by: Felix Cheung <[email protected]>
@asfgit asfgit closed this in 6cff7d1 Jan 5, 2018
@liyinan926 liyinan926 deleted the SPARK-22757 branch January 5, 2018 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants