Skip to content

[SPARK-22771][SQL] Add a missing return statement in Concat.checkInputDataTypes #20149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maropu wants to merge 1 commit into from
Closed

[SPARK-22771][SQL] Add a missing return statement in Concat.checkInputDataTypes #20149

maropu wants to merge 1 commit into from

Conversation

@maropu
Copy link
Member

@maropu maropu commented Jan 4, 2018

What changes were proposed in this pull request?

This pr is a follow-up to fix a bug left in #19977.

How was this patch tested?

Added tests in StringExpressionsSuite.

@maropu
Copy link
Member Author

maropu commented Jan 4, 2018

cc: @gatorsmile

@SparkQA
Copy link

SparkQA commented Jan 4, 2018

Test build #85665 has finished for PR 20149 at commit 2b385ac.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member Author

maropu commented Jan 4, 2018

retest this please

@SparkQA
Copy link

SparkQA commented Jan 4, 2018

Test build #85672 has finished for PR 20149 at commit 2b385ac.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

gatorsmile
gatorsmile reviewed Jan 4, 2018
View reviewed changes
Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gatorsmile
Copy link
Member

gatorsmile commented Jan 4, 2018

Thanks! Merged to master and 2.3

asfgit pushed a commit that referenced this pull request Jan 4, 2018
@maropu @gatorsmile
[SPARK-22771][SQL] Add a missing return statement in Concat.checkInpu…
bcfeef5 
…tDataTypes

## What changes were proposed in this pull request?
This pr is a follow-up to fix a bug left in #19977.

## How was this patch tested?
Added tests in `StringExpressionsSuite`.

Author: Takeshi Yamamuro <[email protected]>

Closes #20149 from maropu/SPARK-22771-FOLLOWUP.

(cherry picked from commit 6f68316)
Signed-off-by: gatorsmile <[email protected]>
@asfgit asfgit closed this in 6f68316 Jan 4, 2018
@maropu
Copy link
Member Author

maropu commented Jan 4, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gatorsmile gatorsmile gatorsmile left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maropu @SparkQA @gatorsmile