Skip to content

[SPARK-22837][SQL]Session timeout checker does not work in SessionManager. #20025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zuotingbing wants to merge 4 commits into from
Closed

[SPARK-22837][SQL]Session timeout checker does not work in SessionManager. #20025

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34b7680
[SPARK-22837][SQL]Session timeout checker does not work in SessionMan…
Dec 20, 2017
79fc11a
fix code review
Jan 17, 2018
5b3c06f
Keep createBackgroundOperationPool unchanged. Looks like the hive thr…
Jan 19, 2018
883deb2
fix code review
Jan 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/SessionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,15 @@ public synchronized void start() {
}
}

private void initSessionTimeoutCheckerConfig() {
Copy link
Member

@felixcheung felixcheung Dec 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we refactor createBackgroundOperationPool to call this?

Copy link
Author

@zuotingbing zuotingbing Dec 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felixcheung . In my opinion you can create a new or follow-up PR if it is necessary. This PR is to fix the bug about the Session Timeout Checker does not work currently.

Copy link
Member

@felixcheung felixcheung Dec 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked because these lines are duplicated
https://github.com/zuotingbing/spark/blob/34b7680dfd915449087b8f5541c682b02df5dfbc/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/SessionManager.java#L105

checkInterval = HiveConf.getTimeVar(
hiveConf, ConfVars.HIVE_SERVER2_SESSION_CHECK_INTERVAL, TimeUnit.MILLISECONDS);
sessionTimeout = HiveConf.getTimeVar(
hiveConf, ConfVars.HIVE_SERVER2_IDLE_SESSION_TIMEOUT, TimeUnit.MILLISECONDS);
checkOperation = HiveConf.getBoolVar(hiveConf,
ConfVars.HIVE_SERVER2_IDLE_SESSION_CHECK_OPERATION);
}

private void startTimeoutChecker() {
final long interval = Math.max(checkInterval, 3000L); // minimum 3 seconds
Runnable timeoutChecker = new Runnable() {
Expand Down
2 changes: 2 additions & 0 deletions ...server/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLSessionManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ private[hive] class SparkSQLSessionManager(hiveServer: HiveServer2, sqlContext:
override def init(hiveConf: HiveConf) {
setSuperField(this, "hiveConf", hiveConf)

invoke(classOf[SessionManager], this, "initSessionTimeoutCheckerConfig")

// Create operation log root directory, if operation logging is enabled
if (hiveConf.getBoolVar(ConfVars.HIVE_SERVER2_LOGGING_OPERATION_ENABLED)) {
invoke(classOf[SessionManager], this, "initOperationLogRootDir")
Expand Down