Skip to content

[SPARK-22760][CORE][YARN] When sc.stop() is called, set stopped is true before removing executors #19951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KaiXinXiaoLei wants to merge 2 commits into from
Closed

[SPARK-22760][CORE][YARN] When sc.stop() is called, set stopped is true before removing executors #19951

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4dcc19
change code
huleilei Dec 11, 2017
40bb11f
code style
Dec 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ...anagers/yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ private[spark] abstract class YarnSchedulerBackend(
sc: SparkContext)
extends CoarseGrainedSchedulerBackend(scheduler, sc.env.rpcEnv) {

private val stopped = new AtomicBoolean(false)

override val minRegisteredRatio =
if (conf.getOption("spark.scheduler.minRegisteredResourcesRatio").isEmpty) {
0.8
Expand Down Expand Up @@ -95,7 +93,6 @@ private[spark] abstract class YarnSchedulerBackend(
requestTotalExecutors(0, 0, Map.empty)
super.stop()
} finally {
stopped.set(true)
services.stop()
}
}
Expand Down Expand Up @@ -209,7 +206,7 @@ private[spark] abstract class YarnSchedulerBackend(
*/
override def onDisconnected(rpcAddress: RpcAddress): Unit = {
addressToExecutorId.get(rpcAddress).foreach { executorId =>
if (!stopped.get) {
if (!sc.isStopped) {
if (disableExecutor(executorId)) {
yarnSchedulerEndpoint.handleExecutorDisconnectedFromDriver(executorId, rpcAddress)
}
Expand Down Expand Up @@ -259,7 +256,7 @@ private[spark] abstract class YarnSchedulerBackend(
addWebUIFilter(filterName, filterParams, proxyBase)

case r @ RemoveExecutor(executorId, reason) =>
if (!stopped.get) {
if (!sc.isStopped) {
logWarning(s"Requesting driver to remove executor $executorId for reason $reason")
driverEndpoint.send(r)
}
Expand Down