[SPARK-22699][SQL] GenerateSafeProjection should not use global variables for struct#19914
Closed
mgaido91 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-22699][SQL] GenerateSafeProjection should not use global variables for struct#19914mgaido91 wants to merge 1 commit intoapache:masterfrom
mgaido91 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@cloud-fan @kiszk @viirya may you please review this? Thanks |
|
Test build #84569 has finished for PR 19914 at commit
|
Member
|
Since |
Contributor
Author
|
@viirya it generates a class, but the changed code and therefore the additional variable is added for each struct object. It might be a problem especially for very complex schemas with nested structs. |
Contributor
|
thanks, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
GenerateSafeProjection is defining a mutable state for each struct, which is not needed. This is bad for the well known issues related to constant pool limits.
The PR replace the global variable with a local one.
How was this patch tested?
added UT