Skip to content

[SPARK-22720] [SS] Make EventTimeWatermark Extend UnaryNode#19913

Closed
gatorsmile wants to merge 1 commit intoapache:masterfrom
gatorsmile:eventtimewatermark
Closed

[SPARK-22720] [SS] Make EventTimeWatermark Extend UnaryNode#19913
gatorsmile wants to merge 1 commit intoapache:masterfrom
gatorsmile:eventtimewatermark

Conversation

@gatorsmile
Copy link
Copy Markdown
Member

@gatorsmile gatorsmile commented Dec 6, 2017

What changes were proposed in this pull request?

Our Analyzer and Optimizer have multiple rules for UnaryNode. After making EventTimeWatermark extend UnaryNode, we do not need a special handling for EventTimeWatermark.

How was this patch tested?

The existing tests

@gatorsmile gatorsmile changed the title [SPARK-22720] [SS] Make EventTimeWatermark UnaryNode [SPARK-22720] [SS] Make EventTimeWatermark Extend UnaryNode Dec 6, 2017
@zsxwing
Copy link
Copy Markdown
Member

zsxwing commented Dec 6, 2017

LGTM

@SparkQA
Copy link
Copy Markdown

SparkQA commented Dec 6, 2017

Test build #84567 has finished for PR 19913 at commit 2ce27df.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Copy Markdown
Member Author

Thanks! Merged to master.

@asfgit asfgit closed this in effca98 Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants