Skip to content

[SPARK-22696][SQL] objects functions should not use unneeded global variables#19908

Closed
mgaido91 wants to merge 3 commits intoapache:masterfrom
mgaido91:SPARK-22696
Closed

[SPARK-22696][SQL] objects functions should not use unneeded global variables#19908
mgaido91 wants to merge 3 commits intoapache:masterfrom
mgaido91:SPARK-22696

Conversation

@mgaido91
Copy link
Copy Markdown
Contributor

@mgaido91 mgaido91 commented Dec 6, 2017

What changes were proposed in this pull request?

Some objects functions are using global variables which are not needed. This can generate some unneeded entries in the constant pool.

The PR replaces the unneeded global variables with local variables.

How was this patch tested?

added UTs

@SparkQA
Copy link
Copy Markdown

SparkQA commented Dec 6, 2017

Test build #84548 has finished for PR 19908 at commit a33bd99.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class ReqAndHandler(req: Request, handler: MemberHandler)
  • trait TypeCoercionRule extends Rule[LogicalPlan] with Logging
  • case class AnalysisBarrier(child: LogicalPlan) extends LeafNode

@mgaido91
Copy link
Copy Markdown
Contributor Author

mgaido91 commented Dec 6, 2017

@cloud-fan @kiszk @viirya may you please review this? Thanks

@SparkQA
Copy link
Copy Markdown

SparkQA commented Dec 6, 2017

Test build #84571 has finished for PR 19908 at commit e7cdbd7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Copy Markdown
Member

viirya commented Dec 7, 2017

LGTM

@cloud-fan
Copy link
Copy Markdown
Contributor

thanks, merging to master!

@asfgit asfgit closed this in b790719 Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants