Skip to content

[SPARK-22690][ML] Imputer inherit HasOutputCols#19889

Closed
zhengruifeng wants to merge 1 commit intoapache:masterfrom
zhengruifeng:using_HasOutputCols
Closed

[SPARK-22690][ML] Imputer inherit HasOutputCols#19889
zhengruifeng wants to merge 1 commit intoapache:masterfrom
zhengruifeng:using_HasOutputCols

Conversation

@zhengruifeng
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

make Imputer inherit HasOutputCols

How was this patch tested?

existing tests

@zhengruifeng
Copy link
Copy Markdown
Contributor Author

No other algs output multi-column for now

@holdenk
Copy link
Copy Markdown
Contributor

holdenk commented Dec 5, 2017

LGTM pending Jenkins.

@SparkQA
Copy link
Copy Markdown

SparkQA commented Dec 5, 2017

Test build #84459 has finished for PR 19889 at commit 5881b88.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zhengruifeng
Copy link
Copy Markdown
Contributor Author

retest this please

@SparkQA
Copy link
Copy Markdown

SparkQA commented Dec 5, 2017

Test build #84462 has finished for PR 19889 at commit 5881b88.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zhengruifeng
Copy link
Copy Markdown
Contributor Author

retest this please

@SparkQA
Copy link
Copy Markdown

SparkQA commented Dec 5, 2017

Test build #84468 has finished for PR 19889 at commit 5881b88.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@MLnick
Copy link
Copy Markdown
Contributor

MLnick commented Dec 6, 2017

LGTM thanks!

@WeichenXu123
Copy link
Copy Markdown
Contributor

LGTM.

@asfgit asfgit closed this in 6f41c59 Dec 6, 2017
@zhengruifeng zhengruifeng deleted the using_HasOutputCols branch December 7, 2017 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants