[SPARK-22529] [SQL] Relation stats should be consistent with other plans based on cbo config #19757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
wzhfy
changed the title
|
Test build #83897 has finished for PR 19757 at commit
|
wzhfy
changed the title
|
Test build #83928 has finished for PR 19757 at commit
|
Contributor
Author
|
retest this please |
|
Test build #83935 has finished for PR 19757 at commit
|
|
Test build #84123 has finished for PR 19757 at commit
|
Contributor
Author
|
retest this please |
|
Test build #84130 has finished for PR 19757 at commit
|
cloud-fan
reviewed
Nov 27, 2017
| Statistics(sizeInBytes = sizeInBytes, rowCount = rowCount, | ||
| attributeStats = AttributeMap(matched)) | ||
| def toPlanStats(planOutput: Seq[Attribute], cboEnabled: Boolean): Statistics = { | ||
| val attrStats = planOutput.flatMap(a => colStats.get(a.name).map(a -> _)) |
cloud-fan
reviewed
Nov 27, 2017
| withSQLConf(SQLConf.CBO_ENABLED.key -> "false") { | ||
| // Don't show rowCount if cbo is disabled | ||
| checkKeywordsExist(sql(explainCostCommand), "sizeInBytes") | ||
| checkKeywordsNotExist(sql(explainCostCommand), "rowCount") |
Contributor
There was a problem hiding this comment.
did you assume there is no table relation cache in this test?
Contributor
Author
There was a problem hiding this comment.
yes, should I refresh it for robustness?
|
Test build #84213 has finished for PR 19757 at commit
|
|
Test build #84218 has finished for PR 19757 at commit
|
Contributor
|
thanks, merging to master! |
gatorsmile
reviewed
Jul 2, 2018
| } else { | ||
| // When CBO is disabled, we apply the size-only estimation strategy, so there's no need to | ||
| // propagate other statistics from catalog to the plan. | ||
| Statistics(sizeInBytes = sizeInBytes) |
Member
There was a problem hiding this comment.
If rowCount is available, why we ignore them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, relation stats is the same whether cbo is enabled or not. While relation (
LogicalRelationorHiveTableRelation) is aLogicalPlan, its behavior is inconsistent with other plans. This can cause confusion when user runs EXPLAIN COST commands. Besides, when CBO is disabled, we apply the size-only estimation strategy, so there's no need to propagate other catalog statistics to relation.How was this patch tested?
Enhanced existing tests case and added a test case.