Skip to content

[SPARK-3076] [Jenkins] catch & report test timeouts #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nchammas wants to merge 3 commits into from
Closed

[SPARK-3076] [Jenkins] catch & report test timeouts #1974

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
279526e
[SPARK-3076] catch & report test timeouts
nchammas Aug 15, 2014
8b1ea41
fix formatting
nchammas Aug 15, 2014
d1f1b6b
set timeout to realistic number
nchammas Aug 15, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 20 additions & 28 deletions dev/run-tests-jenkins
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,27 +26,17 @@
FWDIR="$(cd `dirname $0`/..; pwd)"
cd "$FWDIR"

function get_jq () {
# Get jq so we can parse some JSON, man.
# Essential if we want to do anything with the GitHub API responses.
local JQ_EXECUTABLE_URL="http://stedolan.github.io/jq/download/linux64/jq"

echo "Fetching jq from ${JQ_EXECUTABLE_URL}"

curl --silent --output "$FWDIR/dev/jq" "$JQ_EXECUTABLE_URL"
local curl_status=$?

if [ $curl_status -ne 0 ]; then
echo "Failed to get jq." >&2
return $curl_status
fi

chmod u+x "$FWDIR/dev/jq"
}

COMMENTS_URL="https://api.github.com/repos/apache/spark/issues/$ghprbPullId/comments"
PULL_REQUEST_URL="https://github.com/apache/spark/pull/$ghprbPullId"

COMMIT_URL="https://github.com/apache/spark/commit/${ghprbActualCommit}"
# GitHub doesn't auto-link short hashes when submitted via the API, unfortunately. :(
SHORT_COMMIT_HASH="${ghprbActualCommit:0:7}"

# NOTE: Jenkins will kill the whole build after 120 minutes.
# Tests are a large part of that, but not all of it.
TESTS_TIMEOUT="100m"

function post_message () {
local message=$1
local data="{\"body\": \"$message\"}"
Expand Down Expand Up @@ -96,10 +86,6 @@ function post_message () {
fi
}

COMMIT_URL="https://github.com/apache/spark/commit/${ghprbActualCommit}"
# GitHub doesn't auto-link short hashes when submitted via the API, unfortunately. :(
short_commit_hash=${ghprbActualCommit:0:7}

# check PR merge-ability and check for new public classes
{
if [ "$sha1" == "$ghprbActualCommit" ]; then
Expand Down Expand Up @@ -138,7 +124,7 @@ short_commit_hash=${ghprbActualCommit:0:7}
{
start_message="\
[QA tests have started](${BUILD_URL}consoleFull) for \
PR $ghprbPullId at commit [\`${short_commit_hash}\`](${COMMIT_URL})."
PR $ghprbPullId at commit [\`${SHORT_COMMIT_HASH}\`](${COMMIT_URL})."

start_message="${start_message}\n${merge_note}"
# start_message="${start_message}\n${public_classes_note}"
Expand All @@ -148,21 +134,27 @@ short_commit_hash=${ghprbActualCommit:0:7}

# run tests
{
./dev/run-tests
timeout "${TESTS_TIMEOUT}" ./dev/run-tests
test_result="$?"

if [ "$test_result" -eq "0" ]; then
test_result_note=" * This patch **passes** unit tests."
if [ "$test_result" -eq "124" ]; then
fail_message="**Tests timed out** after a configured wait of \`${TESTS_TIMEOUT}\`."
post_message "$fail_message"
exit $test_result
else
test_result_note=" * This patch **fails** unit tests."
if [ "$test_result" -eq "0" ]; then
test_result_note=" * This patch **passes** unit tests."
else
test_result_note=" * This patch **fails** unit tests."
fi
fi
}

# post end message
{
result_message="\
[QA tests have finished](${BUILD_URL}consoleFull) for \
PR $ghprbPullId at commit [\`${short_commit_hash}\`](${COMMIT_URL})."
PR $ghprbPullId at commit [\`${SHORT_COMMIT_HASH}\`](${COMMIT_URL})."

result_message="${result_message}\n${test_result_note}"
result_message="${result_message}\n${merge_note}"
Expand Down