Skip to content

[SPARK-22413][SQL] Type coercion for IN is not coherent between Literals and subquery #19635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mgaido91 wants to merge 6 commits into from
Closed

[SPARK-22413][SQL] Type coercion for IN is not coherent between Literals and subquery #19635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8fb9c9d
[SPARK-22413][SQL] Type coercion for IN is not coherent between Liter…
mgaido91 Nov 1, 2017
8481b59
use widest type instead of tightest
mgaido91 Nov 2, 2017
c973bb7
style fix
mgaido91 Nov 4, 2017
2db7cf0
Merge branch 'master' into SPARK-22413
mgaido91 Jan 13, 2018
a8723c2
Merge branch 'master' into SPARK-22413
mgaido91 Dec 4, 2019
7656864
fix build
mgaido91 Dec 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ object TypeCoercion {

val commonTypes = lhs.zip(rhs).flatMap { case (l, r) =>
findCommonTypeForBinaryComparison(l.dataType, r.dataType, conf)
.orElse(findTightestCommonType(l.dataType, r.dataType))
.orElse(findWiderTypeForTwo(l.dataType, r.dataType))
Copy link
Member

@gatorsmile gatorsmile Nov 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we make this change?

Copy link
Contributor Author

@mgaido91 mgaido91 Nov 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be coherent with what is done when there are literals instead of a subquery.

}

// The number of columns/expressions must match between LHS and RHS of an
Expand All @@ -493,7 +493,10 @@ object TypeCoercion {
}

case i @ In(a, b) if b.exists(_.dataType != a.dataType) =>
findWiderCommonType(i.children.map(_.dataType)) match {
findWiderCommonType(b.map(_.dataType)).flatMap { listDataType =>
findCommonTypeForBinaryComparison(listDataType, a.dataType, conf)
.orElse(findWiderTypeForTwo(listDataType, a.dataType))
Copy link
Member

@gatorsmile gatorsmile Nov 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason we need to call findWiderTypeForTwo ?

Copy link
Contributor Author

@mgaido91 mgaido91 Nov 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before this PR, we were calling always findWiderCommonType and this was applied to all the elements of the list and the value. Here, I am calling findWiderTypeForTwo if findCommonTypeForBinaryComparison fails to have the same previous behavior in those cases.

} match {
case Some(finalDataType) => i.withNewChildren(i.children.map(Cast(_, finalDataType)))
case None => i
}
Expand Down
8 changes: 8 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1997,6 +1997,14 @@ class DataFrameSuite extends QueryTest with SharedSparkSession {
assert(mean.collect().toSet === Set(Row("0.0345678900000000000000000000000000000")))
}

test("SPARK-22398: type coercion for IN predicates should be coherent") {
val df = spark.range(2)
val inWithLiterals = df.where("id in ('01')")
val inWithSubquery = df.where("id in (select '01' from (select 1))")
assert(inWithLiterals.count() == inWithSubquery.count(),
"IN behavior is not the same with list of Literals and with a subquery")
}

test("SPARK-22520: support code generation for large CaseWhen") {
val N = 30
var expr1 = when($"id" === lit(0), 0)
Expand Down