Skip to content

[SPARK-22215][SQL] Add configuration to set the threshold for generated class #19447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mgaido91 wants to merge 3 commits into from
Closed

[SPARK-22215][SQL] Add configuration to set the threshold for generated class #19447

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c69be31
[SPARK-22215][SQL] Add configuration to set the threshold for generat…
mgaido91 Oct 6, 2017
ed8aaea
use SQLConf instead of SparkEnv
mgaido91 Oct 6, 2017
4c68de6
add internal and check
mgaido91 Oct 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...lyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,11 +279,11 @@ class CodegenContext {
inlineToOuterClass: Boolean = false): String = {
// The number of named constants that can exist in the class is limited by the Constant Pool
// limit, 65,536. We cannot know how many constants will be inserted for a class, so we use a
// threshold of 1600k bytes to determine when a function should be inlined to a private, nested
// sub-class.
// threshold to determine when a function should be inlined to a private, nested sub-class
val generatedClassLengthThreshold = SQLConf.get.generatedClassLengthThreshold
Copy link
Member

@kiszk kiszk Oct 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know this discussion

Copy link
Contributor Author

@mgaido91 mgaido91 Oct 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the interesting link. I assume using SparkEnv has the same problem, hasn't it?

val (className, classInstance) = if (inlineToOuterClass) {
outerClassName -> ""
} else if (currClassSize > 1600000) {
} else if (currClassSize > generatedClassLengthThreshold) {
val className = freshName("NestedClass")
val classInstance = freshName("nestedClassInstance")

Expand Down
11 changes: 11 additions & 0 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,6 +934,15 @@ object SQLConf {
.intConf
.createWithDefault(10000)

val GENERATED_CLASS_LENGTH_THRESHOLD =
buildConf("spark.sql.codegen.generatedClass.size.threshold")
.doc("Threshold in bytes for the size of a generated class. If the generated class " +
Copy link
Member

@maropu maropu Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add .internal(). I think this is not a parameter for users.

Copy link
Contributor Author

@mgaido91 mgaido91 Oct 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my ignorance. If users cannot set it, how can this parameter be changed?

Copy link
Member

@maropu maropu Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not a frequently-used parameter for users. Also, other JVM implimentation-specific parameters are internal, e.g., WHOLESTAGE_HUGE_METHOD_LIMIT. cc: @rednaxelafx

Copy link
Contributor Author

@mgaido91 mgaido91 Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you, but might you please explain me how to set a parameter which is internal? Thanks.

Copy link
Member

@maropu maropu Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users can change this value in the same way with other public parameters, but internal just means that parameters are not explicitly exposed to users.

Copy link
Contributor Author

@mgaido91 mgaido91 Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the explanation, I'll add it immediately.

"size is higher of this value, a private nested class is created and used." +
"This is useful to limit the number of named constants in the class " +
"and therefore its Constant Pool. The default is 1600k.")
.intConf
Copy link
Member

@dongjoon-hyun dongjoon-hyun Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add .checkValue here with a valid minimum and maximum.

.createWithDefault(1600000)

object Deprecated {
val MAPRED_REDUCE_TASKS = "mapred.reduce.tasks"
}
Expand Down Expand Up @@ -1214,6 +1223,8 @@ class SQLConf extends Serializable with Logging {

def arrowMaxRecordsPerBatch: Int = getConf(ARROW_EXECUTION_MAX_RECORDS_PER_BATCH)

def generatedClassLengthThreshold: Int = getConf(GENERATED_CLASS_LENGTH_THRESHOLD)

/** ********************** SQLConf functionality methods ************ */

/** Set Spark SQL configuration properties. */
Expand Down