[SPARK-22154] add a shutdown hook that explains why the output is terminating #19377
Conversation
|
The events of a shutdown are already logged; what does this add? it's already clear something is shutting down |
|
Can one of the admins verify this patch? |
|
It says that "It would be nice to add a shutdown hook here that explains why the output is terminating. Otherwise if the worker dies the executor logs will silently stop" in "TODO",I think it is justified. |
|
Why a shutdown hook instead of something in the lifecycle of this process? |
|
@srowen |
|
Where does the worker exit normally or in case of an error? Why not log there? |
|
@srowen |
|
I'm going to close this PR because it goes stale, please feel free to reopen it or open another PR if anyone have more thoughts on this issue. |
Closes apache#11494 Closes apache#14158 Closes apache#16803 Closes apache#16864 Closes apache#17455 Closes apache#17936 Closes apache#19377 Added: Closes apache#19380 Closes apache#18642 Closes apache#18377 Closes apache#19632 Added: Closes apache#14471 Closes apache#17402 Closes apache#17953 Closes apache#18607 Also cc srowen vanzin HyukjinKwon gatorsmile cloud-fan to see if you have other PRs to close. Author: Xingbo Jiang <[email protected]> Closes apache#19669 from jiangxb1987/stale-prs.
4 participants
It would be nice to add a shutdown hook here that explains why the output is terminating. Otherwise if the worker dies the executor logs will silently stop.