Skip to content

[SPARK-22086][DOCS] Add expression description for CASE WHEN #19304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
viirya wants to merge 1 commit into from
Closed

[SPARK-22086][DOCS] Add expression description for CASE WHEN #19304

viirya wants to merge 1 commit into from

Conversation

@viirya
Copy link
Member

@viirya viirya commented Sep 21, 2017

What changes were proposed in this pull request?

In SQL conditional expressions, only CASE WHEN lacks for expression description. This patch fills the gap.

How was this patch tested?

Only documentation change.

@viirya
Copy link
Member Author

viirya commented Sep 21, 2017

A trivial doc change cc @HyukjinKwon

HyukjinKwon
HyukjinKwon approved these changes Sep 21, 2017
View reviewed changes
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...talyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala Outdated
Copy link
Member

@HyukjinKwon HyukjinKwon Sep 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should return be returns?

Copy link
Member Author

@viirya viirya Sep 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be. I'll fix it. Thanks.

@SparkQA
Copy link

SparkQA commented Sep 21, 2017

Test build #82026 has finished for PR 19304 at commit 4f088d5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 21, 2017

Test build #82031 has finished for PR 19304 at commit e4615bb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Sep 21, 2017

Merged to master.

@asfgit asfgit closed this in 1270e71 Sep 21, 2017
@viirya
Copy link
Member Author

viirya commented Sep 21, 2017

Thanks @HyukjinKwon

@viirya viirya deleted the casewhen-doc branch December 27, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@viirya @SparkQA @HyukjinKwon