Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented Sep 4, 2017

What changes were proposed in this pull request?

If no SparkConf is available to Utils.redact, simply don't redact.

How was this patch tested?

Existing tests

Copy link
Contributor

@darabos darabos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! That was super quick! 🚤

@SparkQA
Copy link

SparkQA commented Sep 4, 2017

Test build #81388 has finished for PR 19123 at commit 735ca94.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM, too.

@hvanhovell
Copy link
Contributor

LGTM, merging to master/2.2. Thanks for picking this up!

asfgit pushed a commit that referenced this pull request Sep 4, 2017
…Exec with sun.io.serialization.extendedDebugInfo=true

## What changes were proposed in this pull request?

If no SparkConf is available to Utils.redact, simply don't redact.

## How was this patch tested?

Existing tests

Author: Sean Owen <[email protected]>

Closes #19123 from srowen/SPARK-21418.

(cherry picked from commit ca59445)
Signed-off-by: Herman van Hovell <[email protected]>
@asfgit asfgit closed this in ca59445 Sep 4, 2017
@srowen srowen deleted the SPARK-21418 branch September 5, 2017 11:29
MatthewRBruce pushed a commit to Shopify/spark that referenced this pull request Jul 31, 2018
…Exec with sun.io.serialization.extendedDebugInfo=true

## What changes were proposed in this pull request?

If no SparkConf is available to Utils.redact, simply don't redact.

## How was this patch tested?

Existing tests

Author: Sean Owen <[email protected]>

Closes apache#19123 from srowen/SPARK-21418.

(cherry picked from commit ca59445)
Signed-off-by: Herman van Hovell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants