Skip to content

Conversation

@mgaido91
Copy link
Contributor

What changes were proposed in this pull request?

When a session is closed the Thriftserver doesn't cancel the jobs which may still be running. This is a huge waste of resources.
This PR address the problem canceling the pending jobs when a session is closed.

How was this patch tested?

The patch was tested manually.

@gatorsmile
Copy link
Member

ok to test

@SparkQA
Copy link

SparkQA commented Aug 16, 2017

Test build #80705 has finished for PR 18951 at commit ac7f0d4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

Copy link
Contributor

@jiangxb1987 jiangxb1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerryshao
Copy link
Contributor

LGTM based on my limited knowledge on area 😄 .

@gatorsmile
Copy link
Member

Thanks! Merging to master.

@asfgit asfgit closed this in 7add4e9 Aug 16, 2017
@dongjoon-hyun
Copy link
Member

Hi, @gatorsmile and @mgaido91 .
Can we have this fix in branch-2.2, too?

@mgaido91
Copy link
Contributor Author

@dongjoon-hyun I think there is no problem, should I submit a new PR on branch-2.2 too then?

@dongjoon-hyun
Copy link
Member

Thank you, @mgaido91 . Please! :)

@gatorsmile
Copy link
Member

This issue is not a regression. That is why I did not merge it to branch-2.2

@dongjoon-hyun
Copy link
Member

I see. @gatorsmile . Sorry, @mgaido91 and @gatorsmile .

@mgaido91 mgaido91 deleted the SPARK-21738 branch August 17, 2017 07:53
@doruchiulan
Copy link

What happens when a connection is not gracefully closed ? (connection.close() not called, process exits). Does sessions somehow listen to underneath Jetty connection and somehow close themselves ?

@RamakrishnaChilaka
Copy link

Can someone please update on @doruchiulan 's statement? I want to know the same thing.

@cloud-fan
Copy link
Contributor

cc @yaooqinn

@yaooqinn
Copy link
Member

yaooqinn commented Aug 3, 2021

FYI, org.apache.thrift.server.TServerEventHandler#deleteContext

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants