[SPARK-19471][SQL]AggregationIterator does not initialize the generated result projection before using it #18946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
ok to test |
gatorsmile
reviewed
Aug 15, 2017
| import org.apache.spark.sql.test.SQLTestData.DecimalData | ||
| import org.apache.spark.sql.types.{Decimal, DecimalType} | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
Please remove this line. Thanks!
gatorsmile
reviewed
Aug 15, 2017
| Seq(Row(3, 4, 9))) | ||
| } | ||
|
|
||
| private def assertNoExceptions(c: Column): Unit = { |
Member
There was a problem hiding this comment.
Could you move it to line 566, just before test("SPARK-21580 ints in aggregation expressions are taken as group-by ordinal.")? Thanks!
Member
|
LGTM except two minor comments. |
|
Test build #80659 has finished for PR 18946 at commit
|
|
Test build #80657 has finished for PR 18946 at commit
|
Contributor
Author
|
Is Jenkin unstable? |
|
Test build #80674 has finished for PR 18946 at commit
|
Member
|
LGTM Thanks! Merging to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up PR that moves the test case in PR-18920 (#18920) to DataFrameAggregateSuit.
How was this patch tested?
unit test