-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-21724][SQL][DOC] Adds since information in the documentation of date functions #18939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @ExpressionDescription( | ||
| usage = "_FUNC_() - Returns the current date at the start of query evaluation.") | ||
| usage = "_FUNC_() - Returns the current date at the start of query evaluation.", | ||
| since = "1.5.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://issues.apache.org/jira/browse/SPARK-8192 - date/time function: current_date. 1.5.0
| @ExpressionDescription( | ||
| usage = "_FUNC_() - Returns the current timestamp at the start of query evaluation.") | ||
| usage = "_FUNC_() - Returns the current timestamp at the start of query evaluation.", | ||
| since = "1.5.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://issues.apache.org/jira/browse/SPARK-8193 - date/time function: current_timestamp. 1.5.0
| 2016-07-31 | ||
| """) | ||
| """, | ||
| since = "1.5.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://issues.apache.org/jira/browse/SPARK-8186 - date/time function: date_add. 1.5.0
| 2016-07-29 | ||
| """) | ||
| """, | ||
| since = "1.5.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://issues.apache.org/jira/browse/SPARK-8187 - date/time function: date_sub. 1.5.0
| 12 | ||
| """) | ||
| """, | ||
| since = "1.5.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://issues.apache.org/jira/browse/SPARK-8181 - date/time function: hour. 1.5.0
| 2016-08-30 15:00:00 | ||
| """) | ||
| """, | ||
| since = "1.5.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://issues.apache.org/jira/browse/SPARK-8191 - date/time function: to_utc_timestamp. 1.5.0
| 2016-12-31 | ||
| """) | ||
| """, | ||
| since = "1.5.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://issues.apache.org/jira/browse/SPARK-8176 - date/time function: to_date. 1.5.0
| 2016-12-31 00:00:00 | ||
| """) | ||
| """, | ||
| since = "2.2.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://issues.apache.org/jira/browse/SPARK-16609 - Single function for parsing timestamps/dates. 2.2.0
| 2015-01-01 | ||
| """) | ||
| """, | ||
| since = "1.5.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://issues.apache.org/jira/browse/SPARK-8197 - date/time function: trunc. 1.5.0
| -1 | ||
| """) | ||
| """, | ||
| since = "1.5.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://issues.apache.org/jira/browse/SPARK-8185 - date/time function: datediff. 1.5.0
|
Test build #80626 has finished for PR 18939 at commit
|
|
retest this please |
|
Test build #80631 has finished for PR 18939 at commit
|
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM, too.
|
LGTM |
|
Thanks! Merging to master. |
|
Thank you @srowen , @dongjoon-hyun and @gatorsmile. |
What changes were proposed in this pull request?
This PR adds
sinceannotation in documentation so that this can be rendered as below:How was this patch tested?
Manually checked the documentation by
cd sql && ./create-docs.sh.Also, Jenkins tests are required.