Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR adds since annotation in documentation so that this can be rendered as below:

2017-08-14 6 54 26

How was this patch tested?

Manually checked the documentation by cd sql && ./create-docs.sh.
Also, Jenkins tests are required.

@ExpressionDescription(
usage = "_FUNC_() - Returns the current date at the start of query evaluation.")
usage = "_FUNC_() - Returns the current date at the start of query evaluation.",
since = "1.5.0")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://issues.apache.org/jira/browse/SPARK-8192 - date/time function: current_date. 1.5.0

@ExpressionDescription(
usage = "_FUNC_() - Returns the current timestamp at the start of query evaluation.")
usage = "_FUNC_() - Returns the current timestamp at the start of query evaluation.",
since = "1.5.0")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://issues.apache.org/jira/browse/SPARK-8193 - date/time function: current_timestamp. 1.5.0

2016-07-31
""")
""",
since = "1.5.0")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://issues.apache.org/jira/browse/SPARK-8186 - date/time function: date_add. 1.5.0

2016-07-29
""")
""",
since = "1.5.0")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://issues.apache.org/jira/browse/SPARK-8187 - date/time function: date_sub. 1.5.0

12
""")
""",
since = "1.5.0")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://issues.apache.org/jira/browse/SPARK-8181 - date/time function: hour. 1.5.0

2016-08-30 15:00:00
""")
""",
since = "1.5.0")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://issues.apache.org/jira/browse/SPARK-8191 - date/time function: to_utc_timestamp. 1.5.0

2016-12-31
""")
""",
since = "1.5.0")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://issues.apache.org/jira/browse/SPARK-8176 - date/time function: to_date. 1.5.0

2016-12-31 00:00:00
""")
""",
since = "2.2.0")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://issues.apache.org/jira/browse/SPARK-16609 - Single function for parsing timestamps/dates. 2.2.0

2015-01-01
""")
""",
since = "1.5.0")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://issues.apache.org/jira/browse/SPARK-8197 - date/time function: trunc. 1.5.0

-1
""")
""",
since = "1.5.0")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://issues.apache.org/jira/browse/SPARK-8185 - date/time function: datediff. 1.5.0

@SparkQA
Copy link

SparkQA commented Aug 14, 2017

Test build #80626 has finished for PR 18939 at commit 1cf870c.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

retest this please

@HyukjinKwon HyukjinKwon changed the title [WIP][SPARK-21724][SQL][DOC] Adds since information in the documentation of date functions [SPARK-21724][SQL][DOC] Adds since information in the documentation of date functions Aug 14, 2017
@SparkQA
Copy link

SparkQA commented Aug 14, 2017

Test build #80631 has finished for PR 18939 at commit 1cf870c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM, too.

@gatorsmile
Copy link
Member

LGTM

@gatorsmile
Copy link
Member

Thanks! Merging to master.

@asfgit asfgit closed this in 0422ce0 Aug 15, 2017
@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Aug 15, 2017

Thank you @srowen , @dongjoon-hyun and @gatorsmile.

@HyukjinKwon HyukjinKwon deleted the add-sinces-date-functions branch January 2, 2018 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants