[SPARK-21675][WebUI]Add a navigation bar at the bottom of the Details for Stage Page#18893
Closed
yaooqinn wants to merge 1 commit intoapache:masterfrom
yaooqinn:SPARK-21675
Closed
[SPARK-21675][WebUI]Add a navigation bar at the bottom of the Details for Stage Page#18893yaooqinn wants to merge 1 commit intoapache:masterfrom yaooqinn:SPARK-21675
yaooqinn wants to merge 1 commit intoapache:masterfrom
yaooqinn:SPARK-21675
Conversation
Member
|
Though I think these should have been separate PRs both these changes LGTM, I'm not sure why the original choice was to only display the pagination nabber at the top and though I'm not usually a fan of adding more column, I think separating these two should be fine. |
Member
Author
|
test this please |
Member
Author
|
@ajbozarth do we need another pr to separate these? if necessary, I will do that. |
Member
|
Since they're both small and this is already open I'd say leave it, unless someone ends up having issues with one of the fixes |
srowen
approved these changes
Aug 11, 2017
Member
srowen
left a comment
There was a problem hiding this comment.
@ajbozarth thanks as ever for reviewing the UI changes. I'm OK with it too if tests pass
|
Test build #3886 has finished for PR 18893 at commit
|
Member
|
Merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?
manually test

Please review http://spark.apache.org/contributing.html before opening a pull request.