Skip to content

[SPARK-21675][WebUI]Add a navigation bar at the bottom of the Details for Stage Page#18893

Closed
yaooqinn wants to merge 1 commit intoapache:masterfrom
yaooqinn:SPARK-21675
Closed

[SPARK-21675][WebUI]Add a navigation bar at the bottom of the Details for Stage Page#18893
yaooqinn wants to merge 1 commit intoapache:masterfrom
yaooqinn:SPARK-21675

Conversation

@yaooqinn
Copy link
Copy Markdown
Member

@yaooqinn yaooqinn commented Aug 9, 2017

What changes were proposed in this pull request?

  1. In Spark Web UI, the Details for Stage Page don't have a navigation bar at the bottom. When we drop down to the bottom, it is better for us to see a navi bar right there to go wherever we what.
  2. Executor ID is not equivalent to Host, it may be better to separate them, and then we can group the tasks by Hosts .

How was this patch tested?

manually test
wx20170809-165606

Please review http://spark.apache.org/contributing.html before opening a pull request.

@ajbozarth
Copy link
Copy Markdown
Member

Though I think these should have been separate PRs both these changes LGTM, I'm not sure why the original choice was to only display the pagination nabber at the top and though I'm not usually a fan of adding more column, I think separating these two should be fine.

@yaooqinn
Copy link
Copy Markdown
Member Author

test this please

@yaooqinn
Copy link
Copy Markdown
Member Author

@ajbozarth do we need another pr to separate these? if necessary, I will do that.

@ajbozarth
Copy link
Copy Markdown
Member

Since they're both small and this is already open I'd say leave it, unless someone ends up having issues with one of the fixes

Copy link
Copy Markdown
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajbozarth thanks as ever for reviewing the UI changes. I'm OK with it too if tests pass

@SparkQA
Copy link
Copy Markdown

SparkQA commented Aug 11, 2017

Test build #3886 has finished for PR 18893 at commit eaf5e52.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Copy Markdown
Member

srowen commented Aug 11, 2017

Merged to master

@asfgit asfgit closed this in 2387f1e Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants