[SPARK-21596] Update StreamExecution.scala #18845
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://issues.apache.org/jira/browse/SPARK-21596 class OffsetSeqLog is subclass of HDFSMetadataLog，so it should ensure places calling OffsetSeqLog.get check the return value also.
Member
|
I'm not clear how this relates to the JIRA. You are just changing an error message. Does this occur in practice? |
Member
|
Is any chance you link to wrong JIRA? |
Contributor
Author
|
[SPARK-21596] means we must check the return value HDFSMetadataLog.get(), so it should ensure all the places taht calling the get() method of subclass of HDFSMetadataLog check the return value. |
ddna1021
changed the title
Member
|
Ok. But there is already a PR created #18799. |
Contributor
Author
|
Ok,that menas my PR is invalid？ |
Member
|
@ddna1021 Thanks for working on this. The PR is created days ago and looks more comprehensive. So I'd suggest we go with that one. |
Contributor
Author
|
Should I close my PR，Sorry，I am a rookie |
|
Can one of the admins verify this patch? |
Member
|
Please close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SPARK-21596]
link to https://issues.apache.org/jira/browse/SPARK-21596
What changes were proposed in this pull request?
class OffsetSeqLog is subclass of HDFSMetadataLog，so it should ensure places calling OffsetSeqLog.get check the return value also.
How was this patch tested?
jenkins