[SPARK-21640] Add errorifexists as a valid string for ErrorIfExists save mode#18844
Closed
ardlema wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-21640] Add errorifexists as a valid string for ErrorIfExists save mode#18844ardlema wants to merge 1 commit intoapache:masterfrom
ardlema wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Jenkins, test this please. |
Member
|
test this please |
|
Test build #80266 has finished for PR 18844 at commit
|
Contributor
|
Actually why do we need this? Can't you just add Error? |
Member
|
Compared with the other mode names, the last one is the only one whose string name do not match the SaveMode enum names. Below is the current one. case "overwrite" => SaveMode.Overwrite
case "append" => SaveMode.Append
case "ignore" => SaveMode.Ignore
case "error" | "default" => SaveMode.ErrorIfExists |
Contributor
|
Ok makes sense. LGTM. |
Member
|
Thanks! Merging to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR includes the changes to make the string "errorifexists" also valid for ErrorIfExists save mode.
How was this patch tested?
Unit tests and manual tests