Skip to content

[SPARK-21640] Add errorifexists as a valid string for ErrorIfExists save mode#18844

Closed
ardlema wants to merge 1 commit intoapache:masterfrom
ardlema:SPARK-21640
Closed

[SPARK-21640] Add errorifexists as a valid string for ErrorIfExists save mode#18844
ardlema wants to merge 1 commit intoapache:masterfrom
ardlema:SPARK-21640

Conversation

@ardlema
Copy link

@ardlema ardlema commented Aug 4, 2017

What changes were proposed in this pull request?

This PR includes the changes to make the string "errorifexists" also valid for ErrorIfExists save mode.

How was this patch tested?

Unit tests and manual tests

@rxin
Copy link
Contributor

rxin commented Aug 4, 2017

Jenkins, test this please.

@gatorsmile
Copy link
Member

test this please

@SparkQA
Copy link

SparkQA commented Aug 5, 2017

Test build #80266 has finished for PR 18844 at commit f8bcf47.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Aug 5, 2017

Actually why do we need this? Can't you just add Error?

@gatorsmile
Copy link
Member

Compared with the other mode names, the last one is the only one whose string name do not match the SaveMode enum names. Below is the current one.

case "overwrite" => SaveMode.Overwrite
case "append" => SaveMode.Append
case "ignore" => SaveMode.Ignore
case "error" | "default" => SaveMode.ErrorIfExists

@rxin
Copy link
Contributor

rxin commented Aug 5, 2017

Ok makes sense. LGTM.

@gatorsmile
Copy link
Member

Thanks! Merging to master

@asfgit asfgit closed this in dcac1d5 Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments