Skip to content

Comments

[SPARK-20713][Spark Core] Convert CommitDenied to TaskKilled.#18819

Closed
nlyu wants to merge 3 commits intoapache:masterfrom
nlyu:SPARK-20713
Closed

[SPARK-20713][Spark Core] Convert CommitDenied to TaskKilled.#18819
nlyu wants to merge 3 commits intoapache:masterfrom
nlyu:SPARK-20713

Conversation

@nlyu
Copy link

@nlyu nlyu commented Aug 2, 2017

What changes were proposed in this pull request?

In executor, toTaskFailedReason is converted to toTaskCommitDeniedReason to avoid the inconsistency of taskState. In JobProgressListener, add case TaskCommitDenied so that now the stage killed number is been incremented other than failed number.
This pull request is picked up from: #18070 using commit: ff93ade
The case match for TaskCommitDenied is added incrementing the correct num of killed after pull/18070.

How was this patch tested?

Run a normal speculative job and check the Stage UI page, should have no failed displayed.

@nlyu
Copy link
Author

nlyu commented Aug 2, 2017

@tgravescs Hi Tom i am Louis Lyu, here is the PR

@tgravescs
Copy link
Contributor

ok to test

case kill: TaskKilled =>
execSummary.reasonToNumKilled = execSummary.reasonToNumKilled.updated(
kill.reason, execSummary.reasonToNumKilled.getOrElse(kill.reason, 0) + 1)
case TaskCommitDenied(jobID, partitionID, attemptNumber) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

give this a variable name like case commitDenied: TaskCommitDenied(jobID, partitionID, attemptNumber) that way you can use the variable commitDenied below in the toErrorString

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay , working on it

stageData.reasonToNumKilled = stageData.reasonToNumKilled.updated(
kill.reason, stageData.reasonToNumKilled.getOrElse(kill.reason, 0) + 1)
Some(kill.toErrorString)
case TaskCommitDenied(jobID, partitionID, attemptNumber) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here use a variable

case kill: TaskKilled =>
jobData.reasonToNumKilled = jobData.reasonToNumKilled.updated(
kill.reason, jobData.reasonToNumKilled.getOrElse(kill.reason, 0) + 1)
case TaskCommitDenied(jobID, partitionID, attemptNumber) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a variable

@SparkQA
Copy link

SparkQA commented Aug 2, 2017

Test build #80164 has finished for PR 18819 at commit 499f1e0.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 2, 2017

Test build #80165 has finished for PR 18819 at commit f975922.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 2, 2017

Test build #80179 has started for PR 18819 at commit 2d5ccb4.

@SparkQA
Copy link

SparkQA commented Aug 3, 2017

Test build #80184 has finished for PR 18819 at commit f975922.

  • This patch fails from timeout after a configured wait of `250m`.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tgravescs
Copy link
Contributor

test this please

@SparkQA
Copy link

SparkQA commented Aug 3, 2017

Test build #80210 has finished for PR 18819 at commit f975922.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tgravescs
Copy link
Contributor

+1

@asfgit asfgit closed this in bb7afb4 Aug 3, 2017
@nlyu
Copy link
Author

nlyu commented Aug 18, 2017

@tgravescs Hi Tom a quick question.
So for the UI data table covert JIRA, is there a corresponding JIRA number in the community for that? Like SPARK-20XXX.

@tgravescs
Copy link
Contributor

@nlyu no please file one

@nlyu nlyu deleted the SPARK-20713 branch August 23, 2018 07:18
@nlyu nlyu restored the SPARK-20713 branch August 23, 2018 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants